Update of images for pacemaker services should be optimized

Bug #1770599 reported by Jiří Stránský
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Unassigned

Bug Description

Currently on minor update we always re-fetch the images, even if the hash hasn't changed. We should only delete old image and re-fetch new one if it's necessary.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/567806

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/567806
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b0322730a7b0759526c3e0b876afa514d8ab35dd
Submitter: Zuul
Branch: master

commit b0322730a7b0759526c3e0b876afa514d8ab35dd
Author: Jiri Stransky <email address hidden>
Date: Fri May 11 11:13:22 2018 +0200

    Fix cinder-backup image wrangling on update

    The minor update tasks for cinder-backup first pull the new image and
    then delete the old one. If the image hasn't changed, deleting the old
    one means deleting the new one too, and then trying to tag it as
    pcmklatest will fail. The other services under
    services/docker/pacemaker seem to have the order correct.

    All services here could use a performance optimization for cases when
    the image hasn't changed (don't reshuffle images if the hash hasn't
    changed) but let's fix the breakage first and address performance
    later.

    Change-Id: I5e0fcb7467fcff7e549e04789ceeb8eb49ee265a
    Closes-Bug: #1770598
    Related-Bug: #1770599

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/569146

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/569146
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=815f99a2d9d4ba206e78bbaf5745c5ce1ff7f9b5
Submitter: Zuul
Branch: stable/queens

commit 815f99a2d9d4ba206e78bbaf5745c5ce1ff7f9b5
Author: Jiri Stransky <email address hidden>
Date: Fri May 11 11:13:22 2018 +0200

    Fix cinder-backup image wrangling on update

    The minor update tasks for cinder-backup first pull the new image and
    then delete the old one. If the image hasn't changed, deleting the old
    one means deleting the new one too, and then trying to tag it as
    pcmklatest will fail. The other services under
    services/docker/pacemaker seem to have the order correct.

    All services here could use a performance optimization for cases when
    the image hasn't changed (don't reshuffle images if the hash hasn't
    changed) but let's fix the breakage first and address performance
    later.

    Change-Id: I5e0fcb7467fcff7e549e04789ceeb8eb49ee265a
    Closes-Bug: #1770598
    Related-Bug: #1770599
    (cherry picked from commit b0322730a7b0759526c3e0b876afa514d8ab35dd)

tags: added: in-stable-queens
Changed in tripleo:
milestone: rocky-3 → rocky-rc1
Changed in tripleo:
milestone: rocky-rc1 → stein-1
Changed in tripleo:
milestone: stein-1 → stein-2
Changed in tripleo:
milestone: stein-2 → stein-3
Changed in tripleo:
milestone: stein-3 → train-1
Changed in tripleo:
milestone: train-1 → train-2
Changed in tripleo:
milestone: train-2 → train-3
Changed in tripleo:
milestone: train-3 → ussuri-1
Revision history for this message
Jiří Stránský (jistr) wrote :

I think https://review.opendev.org/#/c/673456 considerably improved idempotency in this area, closing the bug.

Changed in tripleo:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.