Glance

change webob to 1.8.1 in lower-constraints

Bug #1770410 reported by Brian Rosmaita on 2018-05-10

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Glance	Fix Released	Medium	Brian Rosmaita	Glance stein-1 "18.0.0.0b1"

Bug Description

Can't do this until the requirements team makes webob===1.8.1 in upper-constraints.txt; see https://bugs.launchpad.net/openstack-requirements/+bug/1765748

Four parts to this fix:

(1) webob===1.8.1 in lower-constraints.txt

(2) webob>=1.8.1 in requirements.txt

(3) simplify the code and tests that currently handle both webob 1.7.x and 1.8.x: see https://review.openstack.org/#/c/564883/

(4) add a release note with this content:

Negotiation of the 'Accept-Language' header now follows the "Lookup"
matching scheme described in `RFC 4647, section 3.4
<https://tools.ietf.org/html/rfc4647.html#section-3.4>`_. The
"Lookup" scheme is one of the algorithms suggested in `RFC 7231,
section 5.3.5
<https://tools.ietf.org/html/rfc7231.html#section-5.3.5>`_. (This is
due to a change in an underlying library, which previously used a
matching scheme that did not conform to `RFC 7231
<https://tools.ietf.org/html/rfc7231.html>`_.)

See original description

Revision history for this message

Brian Rosmaita (brian-rosmaita) wrote on 2018-05-17:

webob===1.8.1 was added to upper-contraints.txt by http://git.openstack.org/cgit/openstack/requirements/commit/upper-constraints.txt?id=88bafa11deb9bd7595983d97ffabca338f073ba3

Brian Rosmaita (brian-rosmaita) on 2018-05-20

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-05-20: Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/569644

Changed in glance:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-09: Fix merged to glance (master)

Reviewed: https://review.openstack.org/569644
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=9b9d0567ef2d40c8f20f75a8240abb6fa07ae36c
Submitter: Zuul
Branch: master

commit 9b9d0567ef2d40c8f20f75a8240abb6fa07ae36c
Author: Brian Rosmaita <email address hidden>
Date: Sun May 20 11:41:43 2018 -0400

Use WebOb 1.8.1

    The requirements/upper-constraints file was modified to allow WebOb
    1.8.1 by commit 88bafa11deb9bd7595983d97ffabca338f073ba3. This
    patch simplifies some Glance code that could handle both WebOb
    1.7.4 and 1.8.1 so that it now only handles the latter, and updates
    the glance/requirements.txt and glance/lower-constraints.txt to
    reflect that we support WebOb 1.8.1+ only.

Change-Id: I03e03013927cc5434aa0d97657d5e7efd8223ee5
Closes-bug: #1770410