training site messages not translated

Bug #1767919 reported by tamanegi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

Training site messages like "upgrading soldier evade from level 0 to level 1" shown when hover on that site cannot be translated. Corresponding messages for production sites can be translated as expected.

Widelands version: bzr8668
Platform: Debian testing

In the beginning of constructor of TrainingSiteDescr class (src/logic/map_objects/tribes/trainingsite.cc), the second argument to the parent class constructor which seems to be a message context is empty. I guess it is the cause of this issue.

   : ProductionSiteDescr(init_descname, "", MapObjectType::TRAININGSITE, table, egbase),

If I modify the second argument like this:

   : ProductionSiteDescr(init_descname, table.get_string("msgctxt"), MapObjectType::TRAININGSITE, table, egbase),

the training site messages are translated as expected.

Related branches

tamanegi (tamanegi)
description: updated
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for the fix! I'll create a branch :)

Changed in widelands:
milestone: none → build20-rc1
assignee: nobody → GunChleoc (gunchleoc)
status: New → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.