KiCad

Add Zoom to Selection in View menu bar throughout various apps

Bug #1753339 reported by Andrey Kuznetsov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Low
Wayne Stambaugh
KiCad 5.0.0-rc2

Bug Description

PLEditor has Zoom to Selection in the menu bar and toolbar icon.

All the other apps:
pcbnew
eeschema
gerbview (due to lack of View menu bar - https://bugs.launchpad.net/kicad/+bug/1753337)

Please add Zoom to Selection to the View menu bar with the standard shortcut. Currently it's @ in pleditor, either keep it as @ or change it in ever app.

Wayne Stambaugh (stambaughw)
Changed in kicad:
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Wayne Stambaugh (stambaughw)
milestone: none → 5.0.0-rc2
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 8d8c422a1903db3967d91da9bc603c2b61889ba0
https://git.launchpad.net/kicad/patch/?id=8d8c422a1903db3967d91da9bc603c2b61889ba0

Changed in kicad:
status: In Progress → Fix Committed
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

I just committed the fix for this. I did not add zoom to selection to the viewers because the zoom to selection code is not in place and I am pushing to get v5 released. If you think zoom to selection is important for the viewer, you can file another bug report and I push that off until v6.

Revision history for this message
jean-pierre charras (jp-charras) wrote :

Hi Wayne,

In GAL mode zoom to selection (Ctrl+F5) hotkey does not work (W7 32 bits).
If works in Legacy mode.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: [Bug 1753339] Re: Add Zoom to Selection in View menu bar throughout various apps

@JP, It's appears to be an issue with the tool framework handling to
the command event id. I already emailed Orson about it. I messed
around with it for a while but the tool frame work looks like it has a
conflict in the common and pcb tool zoom selection actions. I don't
have a lot of time to figure this out so I will revert the change if I
can't figure out the issue in a reasonable amount of time

On 03/25/2018 02:27 PM, jean-pierre charras wrote:
> Hi Wayne,
>
> In GAL mode zoom to selection (Ctrl+F5) hotkey does not work (W7 32 bits).
> If works in Legacy mode.
>

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@JP, I figured out the issue. I just merged the fix. Please let me know if your are still having issues.

KiCad Janitor (kicad-janitor)
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.