Mixxx

play/pause shortcuts don't work after clicking rating widget

Bug #1751204 reported by naught101
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
ronso0
Mixxx 2.3.0

Bug Description

If I click the rating widget in decks in Deere (actually using Gramanas' library branch at the moment, but I think this happens in master too), and then I try to use keyboard shortcuts (e.g. d/l for play/pause on the decks), then nothing happens. If I then click any other button, it starts working again. I guess the rating widgets are stealing keyboard focus?

Revision history for this message
jus (jus) wrote :

Confirmed with 2.1.0-beta1 (build 2.1 r6513)

setFocusPolicy(Qt::NoFocus);

Added after
https://github.com/mixxxdj/mixxx/blob/master/src/widget/wstarrating.cpp#L18
and
https://github.com/mixxxdj/mixxx/blob/master/src/library/stareditor.cpp#L45
should fix it.

Plug: How do you think the star rating widget works best - on mouse over, or on press? See lp:1409405

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
ronso0 (ronso0) wrote :

fixed in https://github.com/mixxxdj/mixxx/pull/2307
"keep the library focused when any deck controls or the overview are clicked"

Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
status: Confirmed → Fix Committed
milestone: none → 2.3.0
Daniel Schürmann (daschuer)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9148

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.