Canonical Juju

race in auditconfigupdater test suite

Bug #1749006 reported by Tim Penhey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Christian Muirhead
Canonical Juju 2.4-beta1
2.3
Fix Released
High
Christian Muirhead
Canonical Juju 2.3.4

Bug Description

        ==================
WARNING: DATA RACE
Write at 0x00c4202bf078 by goroutine 71:
  github.com/juju/juju/worker/auditconfigupdater_test.(*updaterSuite).TestIgnoresIrrelevantChange()
      /workspace/src/github.com/juju/juju/worker/auditconfigupdater/worker_test.go:102 +0x5ab
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89

Previous read at 0x00c4202bf078 by goroutine 74:
  github.com/juju/juju/worker/auditconfigupdater_test.(*configSource).ControllerConfig()
      /workspace/src/github.com/juju/juju/worker/auditconfigupdater/worker_test.go:289 +0xd3
  github.com/juju/juju/worker/auditconfigupdater.(*updater).Handle()
      /workspace/src/github.com/juju/juju/worker/auditconfigupdater/worker.go:60 +0x6f
  github.com/juju/juju/watcher/legacy.(*notifyWorker).loop()
      /workspace/src/github.com/juju/juju/watcher/legacy/notifyworker.go:102 +0x32d
  github.com/juju/juju/watcher/legacy.NewNotifyWorker.func1()
      /workspace/src/github.com/juju/juju/watcher/legacy/notifyworker.go:55 +0x64

Goroutine 71 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /workspace/src/gopkg.in/check.v1/check.go:663 +0x430
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /workspace/src/gopkg.in/check.v1/check.go:754 +0x131
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /workspace/src/gopkg.in/check.v1/check.go:809 +0x42
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /workspace/src/gopkg.in/check.v1/check.go:615 +0x1fa
  gopkg.in/check%2ev1.Run()
      /workspace/src/gopkg.in/check.v1/run.go:92 +0x5a
  gopkg.in/check%2ev1.RunAll()
      /workspace/src/gopkg.in/check.v1/run.go:84 +0x136
  gopkg.in/check%2ev1.TestingT()
      /workspace/src/gopkg.in/check.v1/run.go:72 +0x680
  github.com/juju/juju/worker/auditconfigupdater_test.TestPackage()
      /workspace/src/github.com/juju/juju/worker/auditconfigupdater/package_test.go:13 +0x38
  testing.tRunner()
      /snap/go/1404/src/testing/testing.go:746 +0x16c

Goroutine 74 (running) created at:
  github.com/juju/juju/watcher/legacy.NewNotifyWorker()
      /workspace/src/github.com/juju/juju/watcher/legacy/notifyworker.go:53 +0xe6
  github.com/juju/juju/worker/auditconfigupdater.New()
      /workspace/src/github.com/juju/juju/worker/auditconfigupdater/worker.go:45 +0x143
  github.com/juju/juju/worker/auditconfigupdater_test.(*updaterSuite).TestIgnoresIrrelevantChange()
      /workspace/src/github.com/juju/juju/worker/auditconfigupdater/worker_test.go:89 +0x35c
  runtime.call32()
      /snap/go/1404/src/runtime/asm_amd64.s:509 +0x3a
  reflect.Value.Call()
      /snap/go/1404/src/reflect/value.go:302 +0xc0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /workspace/src/gopkg.in/check.v1/check.go:772 +0x9ab
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /workspace/src/gopkg.in/check.v1/check.go:666 +0x89
==================
OK: 6 passed
 testing.go:699: race detected during execution of test

Tim Penhey (thumper)
tags: added: test-failure
removed: test-f
Christian Muirhead (2-xtian)
Changed in juju:
assignee: nobody → Christian Muirhead (2-xtian)
status: Triaged → In Progress
Revision history for this message
Christian Muirhead (2-xtian) wrote :

Fix at https://github.com/juju/juju/pull/8369

Christian Muirhead (2-xtian)
Changed in juju:
status: In Progress → Fix Committed
Revision history for this message
John A Meinel (jameinel) wrote :

(was actually 2.3.3 but this is a test case and is not worth opening a milestone for)
merged from 2.3 into develop from https://github.com/juju/juju/pull/8384

Changed in juju:
milestone: none → 2.4-beta1
Anastasia (anastasia-macmood)
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.