OpenStack Dashboard (Horizon)

network detail tab should be pluggable

Bug #1746754 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Akihiro Motoki
OpenStack Dashboard (Horizon) rocky-1

Bug Description

Some horizon plugin would like to add a tab to the network detail page.
For example, Project networking-bgpvpn would like to add a tab about network-association to the network detail tab. [1]

This can be pluggable via python entrypoints and the similar approach adopted in blueprint horizon-plugin-tab-for-info-and-quotas [2] can be applied.

[1] http://eavesdrop.openstack.org/irclogs/%23openstack-horizon/%23openstack-horizon.2018-02-01.log.html#t2018-02-01T15:18:30
[2] https://blueprints.launchpad.net/horizon/+spec/horizon-plugin-tab-for-info-and-quotas

See original description
Tags: neutron
Akihiro Motoki (amotoki)
description: updated
description: updated
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Considering the bgpvpn implementation, the router detail page also needs to be pluggable.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540097

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/540098

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/540097
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a987c039cfa7943afd5bb9d1aef50c30b32ad8f4
Submitter: Zuul
Branch: master

commit a987c039cfa7943afd5bb9d1aef50c30b32ad8f4
Author: Akihiro Motoki <email address hidden>
Date: Fri Feb 2 02:33:23 2018 +0900

    TabGroup: Make tabs pluggable via horizon plugin config

    This commit enhances django tab implementation to allow horizon plugins
    to add tabs to a tab group in other repository like the main horizon repo.
    New setting "EXTRA_TABS" is introduced to the horizon plugin 'enabled' file.
    To this aim, the tab group class looks up HORIZON_CONFIG['extra_tabs']
    with its class full name and loads them as extra tabs if any.
    HORIZON_CONFIG['extra_tabs'] are populated via horizon plugin settings.

    This commit moves update_settings in openstack_dashboard.test.helpers
    to horizon as I would like to use it in a new horizon unit test.

    blueprint horizon-plugin-tab-for-info-and-quotas
    Closes-Bug: #1746754
    Change-Id: Ice2469a90553754929826d14d20b4719bd1f62d3

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/540098
Reason: TabGroup is now pluggable by the parent patch, so this patch is unnecessary now.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 14.0.0.0b1

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.