[R4.1-84]-SLO: adding tag in SLO does not add associated firewall rules to SLO

Bug #1743508 reported by alok kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R4.1
Fix Committed
High
Ashok Singh
Trunk
Fix Committed
High
Ashok Singh

Bug Description

For SLO, we don't have APIs to add firewall policy/rules in SLO.(reverse is possible).
we have only api add_tag to SLO, which seems to be expected to add all the firewall rules(associated to that tag) to SLO.(just like in case SG and VN policy)

But we don't see firewall rules getting added to SLO by just adding the tags(to SLO).

with this, sessions matching the tags does not get logged.

however, when we add the SLO in firewall policy then sessions get logged, but here we dont have options to configure the SLO rate for each rules.

Need clarification regarding the expected requirement here.

Tags: config vrouter
Revision history for this message
Sachin Bansal (sbansal) wrote :

Where did you see these requirements?

alok kumar (kalok)
description: updated
Revision history for this message
alok kumar (kalok) wrote :

The bug mentions two issue here:
1. adding tag to SLO, which does not log any sessions matching the tags.
2. when we add SLO in firewall policy/rule, we dont have the option to add SLO rate per rule.

As per discussion, issue 1 does not seem to be expected requirement and the session will not be logged by adding tags(but with firewall policy/rules)

issue 2 is still not clear, do we need the SLO rate per firewall rule just like policy/SG rules?
If it's the limitation and we can't support issue 2, please close the bug.

tags: added: vrouter
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39161
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/39162
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39161
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39162
Committed: http://github.com/Juniper/contrail-controller/commit/9cfab2145cafce549eac88906dfa336ceabbdaa9
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 9cfab2145cafce549eac88906dfa336ceabbdaa9
Author: Ashok Singh R <email address hidden>
Date: Tue Jan 23 22:18:57 2018 +0530

Schema change to support slo-rate per firewall policy rule

Partial-Bug: #1743508
(cherry picked from commit 2ac17a07b283b3fcabe454b53e407fbe7b9a299e)

Change-Id: I592b2e1d2596281c4e23cfeb30cea136e4bbd8cd

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39161
Committed: http://github.com/Juniper/contrail-controller/commit/964a072fb0a5c14c48ebdc3014aa1e8e371f0d34
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 964a072fb0a5c14c48ebdc3014aa1e8e371f0d34
Author: Ashok Singh R <email address hidden>
Date: Tue Jan 23 22:18:57 2018 +0530

Schema change to support slo-rate per firewall policy rule

Change-Id: I652b828729e5829a201a900a9c41bf8d71e3c9b2
Partial-Bug: #1743508

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/39320
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39320
Committed: http://github.com/Juniper/contrail-controller/commit/a1f6797f686baeae712f114e674c2e37fa4b1a80
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit a1f6797f686baeae712f114e674c2e37fa4b1a80
Author: Ashok Singh R <email address hidden>
Date: Tue Jan 30 12:13:30 2018 +0530

Handle SLO rate for firewall policy and rules

Parse SLO to firewall-policy and SLO to firewall-rule links and pick
the SLO rate applicable for firewall-policy and rule. This rate will
be used for logging sessions.

Change-Id: I28d9be69afbd2e8b1755c5f83a8c1077b545f1dd
Closes-Bug: #1743508

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39523
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39523
Committed: http://github.com/Juniper/contrail-controller/commit/df3b9dedc4978e0493b175a5f94111324a727caf
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit df3b9dedc4978e0493b175a5f94111324a727caf
Author: Ashok Singh R <email address hidden>
Date: Tue Jan 30 12:13:30 2018 +0530

Handle SLO rate for firewall policy and rules

Parse SLO to firewall-policy and SLO to firewall-rule links and pick
the SLO rate applicable for firewall-policy and rule. This rate will
be used for logging sessions.

Closes-Bug: #1743508
(cherry picked from commit 647d6a24446c242fc83eb12b3fd3744d5246be89)

Change-Id: Idea1cbd2d0f09366c0be0de4b82970b3597e5913

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.