Designate should use "sqlalchemy" pool manager cache driver instead of "memcached"

Bug #1739012 reported by Tytus Kurek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Designate Charm
Fix Released
Low
Tytus Kurek

Bug Description

Currently the designate charm is missing an option to influence the pool manager cache driver and it's using a default setting which is "memcache":

$ cat /etc/designate/designate.conf
...
#cache_driver = memcache
...

Available choices should be:
- noop
- memcache
- sqlalchemy

Revision history for this message
Tytus Kurek (tkurek) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/#/c/529079/

Revision history for this message
James Page (james-page) wrote :

Hi Tytus

Any reason why memcache is not a good idea? I'm not convinced as to the need to expose this as a configuration option - charms are permitted to be opinionated where that's desirable.

Changed in charm-designate:
status: New → Incomplete
importance: Undecided → Low
Revision history for this message
Tytus Kurek (tkurek) wrote :

James,

I'll capture all information around that and will get back to you with a detailed use case soon.

Revision history for this message
Tytus Kurek (tkurek) wrote :

Hi James,

Based on the discussion with Graham Hayes (core Designate developer & original author) the "sqlalchemy" driver is needed for the deployments which require the cache to be resilient, especially deployments with huge zone sizes (hundreds of MB).

Although my environment is not so huge, I would still ask for enabling this option. The change is pretty simple, the "pool_manager_cache:sqlalchemy" section in "designate.conf" file is already configured by the existing templates, and the "memcache" would still remain the default option.

Tytus Kurek (tkurek)
Changed in charm-designate:
assignee: nobody → Tytus Kurek (tkurek)
Revision history for this message
Tytus Kurek (tkurek) wrote :

I've just talked to James offline and we agreed to switch to "sqlalchemy" without introducing charm option. I'll re-write the patch next week.

Changed in charm-designate:
status: Incomplete → In Progress
Tytus Kurek (tkurek)
summary: - Missing option to influence the pool manager cache driver
+ Designate should use "sqlalchemy" pool manager cache driver instead of
+ "memcached"
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-designate (master)

Reviewed: https://review.openstack.org/529079
Committed: https://git.openstack.org/cgit/openstack/charm-designate/commit/?id=ad34f1e889d9bf91ae6ee92f597534857e6e98b7
Submitter: Zuul
Branch: master

commit ad34f1e889d9bf91ae6ee92f597534857e6e98b7
Author: Tytus Kurek <email address hidden>
Date: Mon Jan 29 09:30:58 2018 +0100

    Change pool manager cache driver

    This patchset changes the default pool manager cache driver used by
    the designate charm from "memcached" to "sqlalchemy".

    Change-Id: If61a28f572137b0e3041d17bd9296929074faf7d
    Closes-Bug: #1739012

Changed in charm-designate:
status: In Progress → Fix Committed
Ryan Beisner (1chb1n)
Changed in charm-designate:
milestone: none → 18.02
Ryan Beisner (1chb1n)
Changed in charm-designate:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.