[2.3, HWTv2] badblocks test has 17 badblocks, but test shows as passed.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Lee Trager | ||
2.3 |
Fix Released
|
High
|
Lee Trager |
Bug Description
Badblock test showed as it had "passed", but after checking the log it actually had failed:
Running command: sudo -n badblocks -b 4096 -v -f -n /dev/sdb
Checking for bad blocks in non-destructive read-write mode
From block 0 to 732566645
Testing with random pattern: 49052
65718
65720
65722
65731
66004
66018
110009837
110010192
110010198
110010221
110010558
110010893
111574244
111574248
111574251
111574256
Pass completed, 17 bad blocks found. (17/0/0 errors)
Other things that need to be improve:
Improve the logging similarly to the smartctl logs
INFO: Running command: sudo -n badblocks -b 4096 -v -f -n /dev/sdb
FAILURE: Test FAILED! 17 bad blocks found (17/0/0 errors)
SUCCEES: Test PASSED
-------
Checking for bad blocks in non-destructive read-write mode
From block 0 to 732566645
Testing with random pattern: 49052
65718
65720
65722
65731
66004
66018
110009837
110010192
110010198
110010221
110010558
110010893
111574244
111574248
111574251
111574256
Related branches
- Lee Trager (community): Approve
- MAAS Lander: Pending (unittests) requested
- Andres Rodriguez: Pending requested
-
Diff: 201 lines (+62/-50)2 files modifiedsrc/metadataserver/builtin_scripts/badblocks.py (+49/-18)
src/metadataserver/builtin_scripts/tests/test_badblocks.py (+13/-32)
- MAAS Lander: Approve
- Newell Jensen (community): Approve
-
Diff: 201 lines (+62/-50)2 files modifiedsrc/metadataserver/builtin_scripts/badblocks.py (+49/-18)
src/metadataserver/builtin_scripts/tests/test_badblocks.py (+13/-32)
Changed in maas: | |
milestone: | none → 2.4.x |
milestone: | 2.4.x → 2.4.0alpha1 |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Lee Trager (ltrager) |
description: | updated |
Changed in maas: | |
status: | Triaged → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |