Evergreen

PhantomJS does not support BroadcastChannel

Bug #1731496 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
Evergreen 3.1-beta
3.0
Fix Released
Undecided
Unassigned
Evergreen 3.0.2

Bug Description

Evergreen 3.0.1

Running 'grunt all' (or 'grunt test') fails from JS error:

ReferenceError: Can't find variable: BroadcastChannel

BroadcastChannel is a relatively new object supported by Chrome and FF, but not yet supported in PhantomJS, at least not the version we're running.

Patch en route to avoid instantiating such an object when it does not exist so unit tests can proceed.

Revision history for this message
Bill Erickson (berick) wrote :

Fix:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1731496-broadcast-channel-phantom-fix

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.0.2
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Works!:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1731496-broadcast-channel-phantom-fix

tags: added: signedoff
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Dan Wells (dbw2) wrote :

Pushed to master and rel_3_0. Thank you!

Changed in evergreen:
milestone: 3.0.2 → 3.1-beta
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.