[2.3, HWTv2] Pre-create KVM pod machines do not run hardware tests even though the UI shows they will
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Lee Trager | ||
Bug Description
I came across this issue after this: https:/
So, effectively I have 2 VM's in my libvirt and I do:
1. Add a pod
2. MAAS starts commissioning and the UI shows feedback that testing is going to be run as well.
3. While running commissioning scripts, at a certain point (almost while finishing commissioning), the Hardware Tests tab disappears.
4. The machine is marked ready but no hardware tests are run
It may seem as if:
1. pod starts commissioning *without* hardware testing
2. But since MAAS creates a scriptset before we discover storage, to run tests, it shows them
3. after discovering storage and re-creating the scriptsets, it notices that smartctl-valid was not selected on the start of the call, and removes the UI relating to hardware testing.
Related branches
- Andres Rodriguez (community): Approve
- MAAS Lander: Approve
-
Diff: 323 lines (+62/-55)4 files modifiedsrc/metadataserver/api.py (+0/-3)
src/metadataserver/builtin_scripts/hooks.py (+7/-0)
src/metadataserver/builtin_scripts/tests/test_hooks.py (+55/-23)
src/metadataserver/tests/test_api.py (+0/-29)
| Changed in maas: | |
| milestone: | none → 2.3.0rc2 |
| importance: | Undecided → High |
| status: | New → Triaged |
| assignee: | nobody → Lee Trager (ltrager) |
| summary: |
- [2.3, HWTv2] Re-running commissioning + testing of a NEW machine that - was previously manually aborted results on tests not run + [2.3, HWTv2] Pre-create Pod discovered machines commission but tests are + not run |
| description: | updated |
| summary: |
- [2.3, HWTv2] Pre-create Pod discovered machines commission but tests are - not run + [2.3, HWTv2] Pre-create KVM pod machines do not run hardware tests even + though the UI shows they will |
| description: | updated |
| Andres Rodriguez (andreserl) wrote | #1 |
| Changed in maas: | |
| milestone: | 2.3.0rc2 → 2.3.0 |
| Changed in maas: | |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
After the machine was fully commissioned, I tried to run commissioning *without* any hardware tests, and I saw this error:
Node failed to be commissioned, because of the following error: {"current_