[2.3, UI] Websocket is constantly resending known data
Bug #1722693 reported by
Lee Trager
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Critical
|
Lee Trager | ||
Bug Description
While looking at the websocket traffic using Chrome's network monitor I've noticed MAAS is resending data despite nothing in the system changing.
About every 10 seconds MAAS sends the browser
* An updated node object. As previously mentioned I'm not doing anything with MAAS while this is being sent. My hunch is we're updating the database on every power check, we should only be updating when the power state changes.
* The list of operating systems and kernels which a user can use
* Rack controller image status
* The list of available power types
Sending this data over and over again is causing unnecessary load on the region, network traffic, and making the browser busier for no reason. Only sending data when needed will help performance in large data centers with multiple users.
Related branches
~ltrager/maas:pull_osinfo
- Blake Rouse (community): Approve
- MAAS Lander: Needs Fixing
-
Diff: 595 lines (+82/-244)15 files modifiedMakefile (+1/-1)
src/maasserver/static/js/angular/controllers/add_hardware.js (+15/-23)
src/maasserver/static/js/angular/controllers/node_details.js (+7/-16)
src/maasserver/static/js/angular/controllers/nodes_list.js (+7/-3)
src/maasserver/static/js/angular/controllers/tests/test_add_hardware.js (+8/-44)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+8/-24)
src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+8/-15)
src/maasserver/static/js/angular/directives/machines_table.js (+1/-12)
src/maasserver/static/js/angular/directives/release_name.js (+1/-12)
src/maasserver/static/js/angular/directives/switches_table.js (+1/-12)
src/maasserver/static/js/angular/directives/tests/test_machines_table.js (+1/-26)
src/maasserver/static/js/angular/directives/tests/test_release_name.js (+1/-24)
src/maasserver/static/js/angular/directives/tests/test_switches_table.js (+1/-26)
src/maasserver/static/js/angular/factories/general.js (+14/-5)
src/maasserver/static/js/angular/factories/tests/test_general.js (+8/-1)
~ltrager/maas:no_polling_power_types
- Blake Rouse (community): Approve
-
Diff: 165 lines (+6/-45)6 files modifiedsrc/maasserver/static/js/angular/controllers/add_hardware.js (+1/-8)
src/maasserver/static/js/angular/controllers/node_details.js (+0/-2)
src/maasserver/static/js/angular/controllers/pod_details.js (+0/-2)
src/maasserver/static/js/angular/controllers/tests/test_add_hardware.js (+0/-18)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+2/-2)
src/maasserver/static/js/angular/directives/pod_parameters.js (+3/-13)
~ltrager/maas:only_load_scriptresult_metadata
- Blake Rouse (community): Approve
- MAAS Lander: Needs Fixing
-
Diff: 499 lines (+143/-88)10 files modifiedsrc/maasserver/api/nodes.py (+2/-1)
src/maasserver/models/node.py (+16/-23)
src/maasserver/models/nodeprobeddetails.py (+2/-1)
src/maasserver/status_monitor.py (+31/-7)
src/maasserver/tests/test_status_monitor.py (+26/-7)
src/maasserver/websockets/handlers/node.py (+14/-7)
src/maasserver/websockets/handlers/node_result.py (+20/-16)
src/metadataserver/api.py (+6/-6)
src/metadataserver/models/scriptresult.py (+8/-8)
src/metadataserver/models/scriptset.py (+18/-12)
~ltrager/maas:reduce_node_ws_update
- Newell Jensen (community): Approve
- Andres Rodriguez (community): Needs Information
- MAAS Lander: Needs Fixing
-
Diff: 243 lines (+68/-57)3 files modifiedsrc/maasserver/triggers/testing.py (+0/-2)
src/maasserver/triggers/tests/test_websocket_listener.py (+28/-10)
src/maasserver/triggers/websocket.py (+40/-45)
~ltrager/maas:ws_cache_current_scriptresults_only
- Blake Rouse (community): Approve
-
Diff: 375 lines (+97/-55)6 files modifiedsrc/maasserver/websockets/base.py (+8/-6)
src/maasserver/websockets/handlers/device.py (+9/-1)
src/maasserver/websockets/handlers/machine.py (+0/-11)
src/maasserver/websockets/handlers/node.py (+30/-25)
src/maasserver/websockets/handlers/tests/test_device.py (+1/-1)
src/maasserver/websockets/handlers/tests/test_machine.py (+49/-11)
| Changed in maas: | |
| milestone: | 2.3.0beta3 → 2.3.0beta4 |
| summary: |
- Websocket is constantly resending known data + [2.3, UI] Websocket is constantly resending known data |
| tags: | added: performance |
| tags: | added: ui |
| Changed in maas: | |
| milestone: | 2.3.0beta4 → 2.3.0rc1 |
| Changed in maas: | |
| milestone: | 2.3.0rc1 → 2.3.0rc2 |
| Changed in maas: | |
| milestone: | 2.3.0rc2 → 2.4.x |
| Changed in maas: | |
| milestone: | 2.4.x → 2.4.0beta1 |
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Lee Trager (ltrager) |
Revision history for this message
| Lee Trager (ltrager) wrote | #1 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Closing this as all bugs have been fixed but one which is tracked in LP:1759081