(ansible_distribution == 'RedHat'): 'ansible_distribution' is undefined

Bug #1721790 reported by wes hayutin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
John Trowbridge

Bug Description

https://thirdparty.logs.rdoproject.org/jenkins-tripleo-quickstart-pike-rdo_trunk-baremetal-dell_fc430_envB-single_nic_vlans-58/console.txt.gz

TASK [overcloud-deploy : Use KVM for Red Hat distro] ***************************
task path: /home/rhos-ci/jenkins/workspace/tripleo-quickstart-pike-rdo_trunk-baremetal-dell_fc430_envB-single_nic_vlans/usr/local/share/ansible/roles/overcloud-deploy/tasks/pre-deploy.yml:174
Thursday 05 October 2017 21:52:38 +0000 (0:00:00.129) 0:44:18.441 ******
fatal: [undercloud]: FAILED! => {
    "failed": true,
    "msg": "The conditional check 'ansible_distribution == 'RedHat'' failed. The error was: error while evaluating conditional (ansible_distribution == 'RedHat'): 'ansible_distribution' is undefined\n\nThe error appears to have been in '/home/rhos-ci/jenkins/workspace/tripleo-quickstart-pike-rdo_trunk-baremetal-dell_fc430_envB-single_nic_vlans/usr/local/share/ansible/roles/overcloud-deploy/tasks/pre-deploy.yml': line 174, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Use KVM for Red Hat distro\n ^ here\n"
}

wes hayutin (weshayutin)
tags: added: promotion-blocker quickstart
removed: qui
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-quickstart-extras (master)

Fix proposed to branch: master
Review: https://review.openstack.org/510146

Changed in tripleo:
assignee: nobody → John Trowbridge (trown)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-quickstart-extras (master)

Reviewed: https://review.openstack.org/510146
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=0c451d80eacb2aef648c676c13aac5de6309b64e
Submitter: Jenkins
Branch: master

commit 0c451d80eacb2aef648c676c13aac5de6309b64e
Author: John Trowbridge <email address hidden>
Date: Fri Oct 6 10:46:23 2017 -0400

    Make sure ansible_distribution is defined

    If the ansible_distribution fact is not gathered, then the
    overcloud-deploy role will just fail while trying to
    evaluate it.

    Instead we just make sure it is defined before trying to
    evaluate it. This will have the consequence of any deploy
    which cannot check the ansible_distribution not getting the
    libvirt_args set unless by explicit config. However, that
    seems better than failing outright.

    Closes-Bug: #1721790

    Change-Id: I08c689b949372bae9ffd7eb4ce9576c5b37d138d

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-quickstart-extras 2.1.1

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.