tripleo

Disabling a network in network_data does not cause the network to fallback to ctlplane

Bug #1721542 reported by Tim Rozet on 2017-10-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	Tim Rozet	tripleo queens-1

Bug Description

When disabling a network in the network data file, the network's port object is never created for the role. Therefore it cannot be overridden to noop.yaml, which would cause it to fallback to the ctlplane network. Therefore services mapped to that network never have any IPs and deployment fails. A network which is defined, but disabled should still fallback to the ctlplane network.

Tags:

Tim Rozet (trozet) on 2017-10-05

Changed in tripleo:
status:	New → In Progress
importance:	Undecided → Medium
assignee:	nobody → Tim Rozet (trozet)
milestone:	none → queens-1
tags:	added: pike-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-05: Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/509789

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-10: Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/511005

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-10: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/509789
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9285cb5fc99331ca63ff09df59f26b6018bc781b
Submitter: Jenkins
Branch: master

commit 9285cb5fc99331ca63ff09df59f26b6018bc781b
Author: Tim Rozet <email address hidden>
Date: Thu Oct 5 09:59:49 2017 -0400

Fixes dynamic networks falling back to ctlplane

    Currently when a network in network_data is disabled it no port
    definitions for that network will be created per role. This results in
    no fallback to the ctlplane IP because overriding a type in
    network-isolation to noop.yaml does nothing when the port does not exist
    for the role.

    This patch changes the IPs when a network is disabled to be the same IPs
    as ctlplane and fixes the issue, along with removing the need to use
    noop.yaml override for ports (non-vip).

Closes-Bug: 1721542

Change-Id: I301370fbf47a71291614dd60e4c64adc7b5ebb42
Signed-off-by: Tim Rozet <email address hidden>

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-16: Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/511005
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e0a0cb8974ccbfdb9f8f4477f15094ba8d048e55
Submitter: Zuul
Branch: stable/pike

commit e0a0cb8974ccbfdb9f8f4477f15094ba8d048e55
Author: Tim Rozet <email address hidden>
Date: Thu Oct 5 09:59:49 2017 -0400

Fixes dynamic networks falling back to ctlplane

    This patch changes the IPs when a network is disabled to be the same IPs
    as ctlplane and fixes the issue, along with removing the need to use
    noop.yaml override for ports (non-vip).

Closes-Bug: 1721542

    Change-Id: I301370fbf47a71291614dd60e4c64adc7b5ebb42
    Signed-off-by: Tim Rozet <email address hidden>
    (cherry picked from commit 9285cb5fc99331ca63ff09df59f26b6018bc781b)