tripleo

parameterInput conditional checks parameter types in wrong order

Bug #1721520 reported by Jiri Tomasek on 2017-10-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Jiri Tomasek	tripleo queens-1

Bug Description

ParameterInput component in tripleo-ui does object/json parameter type chaeck before checking comma_delimited_list type. Due to that the comma_delimited_list type parameters are rendered as json values and client side validation fails.

Fix: check comma_delimited_list type before json type in ParameterInput component

Tags:

OpenStack Infra (hudson-openstack) on 2017-10-05

Changed in tripleo:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-17: Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/508860
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=19145a498b6dff227cb30f4485b0a3b137fd3a3c
Submitter: Zuul
Branch: master

commit 19145a498b6dff227cb30f4485b0a3b137fd3a3c
Author: Jiri Tomasek <email address hidden>
Date: Mon Sep 25 12:34:23 2017 +0200

Fix ParameterInput component

    * correctly handle comma_delimited_list parameter types
    * don't limit minimum value of number type parameters as certain
      parameters require a negative value
    * fix HorizontalStaticText value prop

Closes-Bug: 1721520
Change-Id: If1b4138b45b93190f7d03c661d0e90db1e4846c4

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-18: Fix proposed to tripleo-ui (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/512955

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-10-18: Fix merged to tripleo-ui (stable/pike)

Reviewed: https://review.openstack.org/512955
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=de71097190c66340685e4202171f33d310d2093e
Submitter: Zuul
Branch: stable/pike

commit de71097190c66340685e4202171f33d310d2093e
Author: Jiri Tomasek <email address hidden>
Date: Mon Sep 25 12:34:23 2017 +0200

Fix ParameterInput component

    Closes-Bug: 1721520
    Change-Id: If1b4138b45b93190f7d03c661d0e90db1e4846c4
    (cherry picked from commit 19145a498b6dff227cb30f4485b0a3b137fd3a3c)