OpenStack Shared File Systems Service (Manila)

exception when downgrading db from '579c267fbb4d' to '5077ffcc5f1c'

Bug #1717392 reported by zhiguo.li on 2017-09-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Medium	Goutham Pacha Ravi	OpenStack Shared File Systems Service (Manila) rocky-3 "R-3"

Bug Description

When running method downgrade() in 579c267fbb4d_add_share_instances_access_map.py, an exception may occur if the 'access_mapping' is None type.
The exception is like this: TypeError: 'NoneType' object has no attribute '__getitem__'.

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-15: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/504296

Changed in manila:
assignee:	nobody → zhiguo.li (zhiguo)
status:	New → In Progress

Goutham Pacha Ravi (gouthamr) on 2017-09-18

Changed in manila:
importance:	Undecided → Medium
milestone:	none → queens-1

Revision history for this message

zhiguo.li (zhiguo) wrote on 2017-09-18: Re: Exsist exception when downgrading db from '579c267fbb4d' to '5077ffcc5f1c'

Beginning state of the database.xlsx Edit (9.7 KiB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)

I uploaded the data exported from table 'share_instance_access_map' and 'share_access_map' for explaing this bug.

OpenStack Infra (hudson-openstack) on 2018-06-09

Changed in manila:
assignee:	zhiguo.li (zhiguo) → Tom Barron (tpb)

Tom Barron (tpb) on 2018-06-19

summary:	- Exsist exception when downgrading db from '579c267fbb4d' to - '5077ffcc5f1c' + exception when downgrading db from '579c267fbb4d' to '5077ffcc5f1c'
Changed in manila:
assignee:	Tom Barron (tpb) → nobody
assignee:	nobody → zhiguo.li (zhiguo)
tags:	added: db-migration

Goutham Pacha Ravi (gouthamr) on 2018-06-20

Changed in manila:
milestone:	queens-1 → rocky-3

OpenStack Infra (hudson-openstack) on 2018-06-25

Changed in manila:
assignee:	zhiguo.li (zhiguo) → Goutham Pacha Ravi (gouthamr)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-27: Fix merged to manila (master)

Reviewed: https://review.openstack.org/504296
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=12841fe01656d2cd4ae1e8b69d02dd7ff9e1a3a4
Submitter: Zuul
Branch: master

commit 12841fe01656d2cd4ae1e8b69d02dd7ff9e1a3a4
Author: zhiguo.li <email address hidden>
Date: Fri Sep 15 09:32:52 2017 +0800

DB Migration: fix downgrade in 579c267fbb4d

The downgrade incorrectly modifies deleted
share access rules.

Also add a missing unit test for this migration.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>
    Change-Id: If3700e7a18cbd8ae496b8c503c95cf6723485679
    Closes-Bug: #1717392

Changed in manila:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-29: Fix proposed to manila (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/579236

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-07-25: Fix merged to manila (stable/queens)

Reviewed: https://review.openstack.org/579236
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=846a1597d342feaa58d4c773eae22c880f031508
Submitter: Zuul
Branch: stable/queens

commit 846a1597d342feaa58d4c773eae22c880f031508
Author: zhiguo.li <email address hidden>
Date: Fri Sep 15 09:32:52 2017 +0800

DB Migration: fix downgrade in 579c267fbb4d

The downgrade incorrectly modifies deleted
share access rules.

Also add a missing unit test for this migration.

    Co-Authored-By: Goutham Pacha Ravi <email address hidden>
    Change-Id: If3700e7a18cbd8ae496b8c503c95cf6723485679
    Closes-Bug: #1717392
    (cherry picked from commit 12841fe01656d2cd4ae1e8b69d02dd7ff9e1a3a4)