tripleo

Composable networks failing upgrades due to missing management network files.

Bug #1717123 reported by Dan Sneddon on 2017-09-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Dan Sneddon	tripleo queens-1

Bug Description

Composable networks works by creating network and port files on the fly according to the contents of network_data.yaml. This introduced a new method for enabling/disabling the management network, but upgrades using existing network environment files will fail to find the management network files.

Since the old method was deprecated, we should support upgrades for at least one cycle. The Management network should be enabled by default so the management network templates will be rendered, even though the default roles do not include the Management network. This will allow custom environment files from older versions to still work during upgrades.

In Queens, we can remove some of the legacy files, such as environments/network-isolation-no-tunneling.yaml and network-isolation-management.yaml, and rely on the settings in network_data.yaml and the role definitions to generate the correct network config files on the fly.

Tags:

Dan Sneddon (dsneddon) on 2017-09-13

Changed in tripleo:
status:	New → Triaged
importance:	Undecided → High
assignee:	nobody → Dan Sneddon (dsneddon)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-14: Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/503879

Changed in tripleo:
status:	Triaged → In Progress

Emilien Macchi (emilienm) on 2017-09-14

Changed in tripleo:
milestone:	none → queens-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-22: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/503879
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5b9fbc2b2bfa00de2fe0f437f21e05e3fc09a53d
Submitter: Jenkins
Branch: master

commit 5b9fbc2b2bfa00de2fe0f437f21e05e3fc09a53d
Author: Dan Sneddon <email address hidden>
Date: Wed Sep 13 17:53:36 2017 -0600

Fix upgrades that use Management network

    Upgrades from older versions using Management network fail.
    This patch enables the management network even though it is not
    enabled in any of the role definitions. This will allow upgrades
    to complete using existing network environment files, without
    requiring operators to switch to the new method for defining
    which networks are attached to roles. Eventually these older
    environment files will be removed.

Change-Id: Iadd12a559f0ad6918958a1355f189187fd327363
Closes-bug: 1717123

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-22: Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/506806

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-09-27: Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/506806
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5a94449b77d6b52c99dd5581fde44b73b1d34f85
Submitter: Jenkins
Branch: stable/pike

commit 5a94449b77d6b52c99dd5581fde44b73b1d34f85
Author: Dan Sneddon <email address hidden>
Date: Wed Sep 13 17:53:36 2017 -0600

Fix upgrades that use Management network

    Change-Id: Iadd12a559f0ad6918958a1355f189187fd327363
    Closes-bug: 1717123
    (cherry picked from commit 5b9fbc2b2bfa00de2fe0f437f21e05e3fc09a53d)