Partition and VG API endpoints diverge
Bug #1715230 reported by
Scott Hussey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Lee Trager | ||
Bug Description
The API endpoints dealing with partitions and volume-groups both diverge when addressing collections vs single resources
Collections:
Partitions = /api/2.
Volume Groups = /api/2.
Single Resource:
Partition = /api/2.
Volume Group = /api/2.
I would expect in a RESTful API, or even a REST-like API, that the endpoints for a collection and a resource to be identical with extra resource-id appended.
Related branches
~ltrager/maas:lp1715230
- Andres Rodriguez (community): Approve
-
Diff: 103 lines (+26/-10)3 files modifiedsrc/maasserver/api/tests/test_partitions.py (+7/-2)
src/maasserver/api/tests/test_volume_groups.py (+12/-6)
src/maasserver/urls_api.py (+7/-2)
~andreserl/maas:lp1715230
- MAAS Lander: Needs Fixing
- Lee Trager (community): Needs Information
- Blake Rouse: Pending requested
-
Diff: 18 lines (+2/-2)1 file modifiedsrc/maasserver/urls_api.py (+2/-2)
Revision history for this message
| Blake Rouse (blake-rouse) wrote | #1 |
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| milestone: | none → 2.3.0 |
Revision history for this message
| Scott Hussey (sh8121) wrote | #2 |
| Changed in maas: | |
| milestone: | 2.3.0 → 2.3.x |
| Changed in maas: | |
| milestone: | 2.3.x → 2.5.0 |
| tags: | added: track |
| Changed in maas: | |
| milestone: | 2.5.0 → 2.5.0beta2 |
| Changed in maas: | |
| assignee: | nobody → Andres Rodriguez (andreserl) |
| status: | Triaged → In Progress |
| Changed in maas: | |
| assignee: | Andres Rodriguez (andreserl) → Lee Trager (ltrager) |
| status: | In Progress → New |
| status: | New → Confirmed |
| Changed in maas: | |
| status: | Confirmed → In Progress |
| Changed in maas: | |
| milestone: | 2.5.0beta2 → 2.5.0rc1 |
| Changed in maas: | |
| milestone: | 2.5.0rc1 → 2.5.0beta2 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Are you specifically calling out the difference between?
/api/2.
and
/api/2.
?
You are correct in that it should be "volume-groups". That is just a typo that was not caught in the code during implementation and code review.