kolla-ansible

outward rabbitmq prechecks not idempotent

Bug #1715135 reported by John Garbutt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
High
John Garbutt
kolla-ansible pike-rc1 "pike"

Bug Description

If you enable murano, the outward_rabbitmq container is started. Once started the pre-checks start to fail when checking if the port is free, because the service has already been stared.

There is a nice pattern in use to skip such prechecks for the regular rabbitmq container, reusing those is probably be best way forward.

Seems this was introduced in change:
https://review.openstack.org/#q,d8fe3ea780c188b6e937ab6f08a8475d2330a9fa,n,z

Revision history for this message
John Garbutt (johngarbutt) wrote :

Uploaded patch: https://review.openstack.org/#/c/500765/

Changed in kolla-ansible:
assignee: nobody → John Garbutt (johngarbutt)
status: New → In Progress
Eduardo Gonzalez (egonzalez90)
Changed in kolla-ansible:
milestone: none → pike-rc1
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/500765
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=7e9fa0cd41b72d157f4c88f9ec533aafd60bfefe
Submitter: Jenkins
Branch: master

commit 7e9fa0cd41b72d157f4c88f9ec533aafd60bfefe
Author: John Garbutt <email address hidden>
Date: Tue Sep 5 11:17:59 2017 +0100

    Make outward_rabbit pre-checks idempotent

    Copy the patterns from the rabbit checks, skip some pre-checks when the
    container has already been started. Without this change the pre-checks
    fail when you re-run the deploy, i.e. the port is not free because
    rabbit is already running on that port.

    This bug was triggered because murano is enabled, and this change has
    been added to add the extra rabbitmq instance by default:
    d8fe3ea780c188b6e937ab6f08a8475d2330a9fa

    Closes-Bug: #1715135

    Change-Id: I0eb8785e7cd4eadfa792ea14a27f54a891b2bf02

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/503636

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/pike)

Reviewed: https://review.openstack.org/503636
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=d3d56d5f42b674ddebf2cdbf4eabf2d541a25edc
Submitter: Jenkins
Branch: stable/pike

commit d3d56d5f42b674ddebf2cdbf4eabf2d541a25edc
Author: John Garbutt <email address hidden>
Date: Tue Sep 5 11:17:59 2017 +0100

    Make outward_rabbit pre-checks idempotent

    Copy the patterns from the rabbit checks, skip some pre-checks when the
    container has already been started. Without this change the pre-checks
    fail when you re-run the deploy, i.e. the port is not free because
    rabbit is already running on that port.

    This bug was triggered because murano is enabled, and this change has
    been added to add the extra rabbitmq instance by default:
    d8fe3ea780c188b6e937ab6f08a8475d2330a9fa

    Closes-Bug: #1715135

    Change-Id: I0eb8785e7cd4eadfa792ea14a27f54a891b2bf02
    (cherry picked from commit 7e9fa0cd41b72d157f4c88f9ec533aafd60bfefe)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 6.0.0.0b2

This issue was fixed in the openstack/kolla-ansible 6.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 5.0.1

This issue was fixed in the openstack/kolla-ansible 5.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.