OpenStack Heat

update volume failed if enable observe

Bug #1712041 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
huangtianhua
OpenStack Heat queens-1

Bug Description

1. create a stack with a cinder volume:
resources:
  test_vol:
    type: OS::Cinder::Volume
    properties:
      size: {get_param: size}
      volume_type: lvmdriver-1
      read_only: false
2. update the stack without change anything, stack create failed: NotFound: resources.v1: The resource could not be found.

huangtianhua (huangtianhua)
Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
importance: Undecided → Medium
Revision history for this message
huangtianhua (huangtianhua) wrote :

For this bug I found two problems:
1. Heat updates the volume_reality with property 'read_only' from the live data when parse_live_resource_data(), but in
fact cinder returns the key 'readonly' in volume details info, not the key 'read_only'
2. because the reason above, heat will call update_all_metadata() when handle_update(), there is a bug in cinder, all metadata api can be used since the microversion 3.15, and I found a bug of cinder: https://bugs.launchpad.net/cinder/+bug/1712192

So, we fix the first problem in heat.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/496135

Changed in heat:
status: New → In Progress
huangtianhua (huangtianhua)
Changed in heat:
milestone: none → queens-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/496135
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=72be5266ee4ab08808a026bff2420dd2ffa1d55f
Submitter: Jenkins
Branch: master

commit 72be5266ee4ab08808a026bff2420dd2ffa1d55f
Author: huangtianhua <email address hidden>
Date: Tue Aug 22 15:31:14 2017 +0800

    Parse live data with correct key 'readonly'

    Cinder returns the volume infos with key 'readonly',
    not 'read_only', so parse live data with correct key
    'readonly' for volume resource.

    Change-Id: If19db3129f23a6cb9d19e6744c4ffc4522166426
    Closes-Bug: #1712041

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/499414

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/pike)

Reviewed: https://review.openstack.org/499414
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=971b2f6bad93bb1d20b608ce9a4c997fc7e6bbd0
Submitter: Jenkins
Branch: stable/pike

commit 971b2f6bad93bb1d20b608ce9a4c997fc7e6bbd0
Author: huangtianhua <email address hidden>
Date: Tue Aug 22 15:31:14 2017 +0800

    Parse live data with correct key 'readonly'

    Cinder returns the volume infos with key 'readonly',
    not 'read_only', so parse live data with correct key
    'readonly' for volume resource.

    Change-Id: If19db3129f23a6cb9d19e6744c4ffc4522166426
    Closes-Bug: #1712041
    (cherry picked from commit 72be5266ee4ab08808a026bff2420dd2ffa1d55f)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 10.0.0.0b1

This issue was fixed in the openstack/heat 10.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 9.0.1

This issue was fixed in the openstack/heat 9.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.