Web Staff Client: Missing info on Hold Shelf List print template

Bug #1708489 reported by Terran McCanna
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.12
Fix Released
Low
Unassigned

Bug Description

The current status and the shelf expire date were both available in the xul client's print template and don't appear to be available in webby's print template.

These are both useful when clearing out cancelled holds and holds that haven't been picked up from the shelf.

Revision history for this message
Terran McCanna (tmccanna) wrote :

Update: The status is available by using hold_data.status_string - I don't see the shelf expire date though.

Changed in evergreen:
importance: Undecided → Low
Revision history for this message
Andrea Neiman (aneiman) wrote :

Confirmed 3.0 beta, shelf expiry still appears unavailable to Hold Shelf template.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Kyle Huckins (khuckins) wrote :
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
tags: added: pullrequest
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
Revision history for this message
Kyle Huckins (khuckins) wrote :

Actually, I may have misinterpereted this issue to be about setting them as default, as opposed to being available to grab for customization - as Terran pointed out, hold_data.status_string gets us the status, while hold_data.hold.shelf_expire_time gets us the shelf expire date already.

Revision history for this message
Kathy Lussier (klussier) wrote :

FWIW, I think it's useful to have the hold_data.hold.shelf.expire_time as a default field to display on this template. I'm ambivalent about the status, but adding these fields to the documentation at the top of the receipt is a good thing (I see you've done this.)

Revision history for this message
Terran McCanna (tmccanna) wrote :

I've confirmed that hold_data.hold.shelf_expire_time works on the print template (note that it as well as status are broken in the print preview).

Revision history for this message
Kyle Huckins (khuckins) wrote :

I've amended my previous commit with some additions to the sample data, should do the trick.

Revision history for this message
Kathy Lussier (klussier) wrote :

Works for me! I made a slight adjustment to the sample data to use a status that would be on a real-world holds shelf and merged the branch to master, release 3.0 and release 2.12.

Thanks Kyle and Terran!

Galen Charlton (gmc)
Changed in evergreen:
milestone: none → 3.0.2
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.