Check Number in Bill History

Confirming that check number is not a column picker option in Bill History in either the xul or web client.

Here's a branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp_1705693_check_number_bill_history

Feedback Fest 2/8/2021 comment:

Is this patch supposed to be only applied to "Payments" tab in Bill History?

It looks like the code was changed for both Payments and Transaction Details

Ah, not Bills > History > Transactions, though.

Upon considering this further, I'm not sure that it really makes sense to have check number in the transaction history tab -- a transaction can have multiple payments, in which case there can be multiple check numbers.

Double-clicking on the transaction opens the bill details, where all of the payments in the transaction with their check numbers ARE displayed with this patch. So, I'm going to go ahead and sign off on this patch because it's a useful improvement as-is:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp_1705693_check_number_bill_history_signoff

If anyone thinks that either *all check numbers* or *last check number* should be added to the Bills > History > Transactions tab, please create a new wish list ticket and specify your preference between the two.

Pushed to master for inclusion in 3.7. Thanks, Dan and Terran!