widelands

Instantiation warnings from maptriangleregion.h

Bug #1699852 reported by Klaus Halfmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned
widelands build20-rc1

Bug Description

When compiling on OSX with Apple LLVM version 8.1.0 (clang-802.0.42)

I get 6 warnings like

src/wui/interactive_base.cc:168:34: warning: instantiation of function
      'Widelands::MapTriangleRegion<Widelands::TCoords<Widelands::Coords>, unsigned short>::MapTriangleRegion' required here, but no definition is
      available [-Wundefined-func-template]
                Widelands::MapTriangleRegion<> mr(map, Area<TCoords<>>(center.triangle, sel_.radius));

from src/logic/maptriangleregion.h

This should be fixed along the suggestions in
https://docs.microsoft.com/de-de/cpp/cpp/explicit-instantiation.

Maybe the code could get some more comments, too.
So I can understand why it was done _that_ way :-)

Perhaps the compiler is just to picky and we can just igore this one?

Tags: cleanups macos

Related branches

lp://staging/~widelands-dev/widelands/bug-1699852-compiler-warning
Klaus Halfmann: Approve (review, compile)
Diff: 47 lines (+15/-0)
3 files modified
src/logic/mapfringeregion.h (+4/-0)
src/logic/maphollowregion.h (+4/-0)
src/logic/maptriangleregion.h (+7/-0)
GunChleoc (gunchleoc)
summary: - instatitation warnings from maptriangleregion.h
+ Instantiation warnings from maptriangleregion.h
Changed in widelands:
status: New → Confirmed
tags: added: cleanups macos
Revision history for this message
SirVer (sirver) wrote :

I do not spot these warnings in CI, for example: https://travis-ci.org/widelands/widelands/jobs/270745948

Are these still there for you?

Changed in widelands:
status: Confirmed → Incomplete
SirVer (sirver)
Changed in widelands:
assignee: SirVer (sirver) → Klaus Halfmann (klaus-halfmann)
Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

Sorry I will not have access to my Mac for quite some time,
so no chance to test this, sorry.

Feel freee to close it. I will reopen a new one oce things
haven changed.

Revision history for this message
GunChleoc (gunchleoc) wrote :

We switched them off in CMakeLists.txt, because they're noisy as hell. There's a TODO comment there though, recommending to fix them.

GunChleoc (gunchleoc)
Changed in widelands:
status: Incomplete → Confirmed
GunChleoc (gunchleoc)
Changed in widelands:
assignee: Klaus Halfmann (klaus-halfmann) → GunChleoc (gunchleoc)
milestone: none → build20-rc1
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.