tripleo

On pacemaker remote node stonith is set unconditionally

Bug #1696336 reported by Michele Baldessari on 2017-06-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Michele Baldessari	tripleo pike-3 "pike-3"

Bug Description

We have the following code currently in the tripleo pacemaker_remote manifest:
class tripleo::profile::base::pacemaker_remote (
  $remote_authkey,
  $pcs_tries = hiera('pcs_tries', 20),
  $enable_fencing = hiera('enable_fencing', false),
  $step = hiera('step'),
) {
  class { '::pacemaker::remote':
    remote_authkey => $remote_authkey,
  }
  $enable_fencing_real = str2bool($enable_fencing) and $step >= 5

  class { '::pacemaker::stonith':
    disable => !$enable_fencing_real,
    tries => $pcs_tries,
  }
....

It makes no sense to enforce the stonith on the remote nodes and we should probably just enforce
it on $pacemaker_master anyway. While this works in general it creates extra CIB changes for nothing and we did see an issue when working with container HA (due to the remotes not being up already)

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-07: Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/471630

Changed in tripleo:
assignee:	nobody → Michele Baldessari (michele)
status:	Triaged → In Progress

Emilien Macchi (emilienm) on 2017-06-08

Changed in tripleo:
milestone:	pike-2 → pike-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-16: Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/471630
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=332755c0fd586f0a3085704b3f4bda78ad8a87ad
Submitter: Jenkins
Branch: master

commit 332755c0fd586f0a3085704b3f4bda78ad8a87ad
Author: Michele Baldessari <email address hidden>
Date: Wed Jun 7 10:20:25 2017 +0200

Only set the stonith property on the pacemaker_master node

    It makes little sense to enforce the stonith property on remote nodes and/or
    all cluster nodes. We can just enforce it once on the pacemaker_master
    node as it is a cluster-wide property anyway. We can also remove the
    tripleo::fencing -> pacemaker::stonith constraint in the pacemaker
    remote profile now as the fencing stuff happens on step 5 anyway and
    the property is set at step 1.

While this works in general it creates extra CIB changes for nothing and
slows down the deployment.

Change-Id: Ifef08033043a4cc90a6261e962d2fdecdf275650
Closes-Bug: #1696336

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-19: Fix proposed to puppet-tripleo (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/485251

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-20: Fix merged to puppet-tripleo (stable/ocata)

Reviewed: https://review.openstack.org/485251
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=b7c038380045614ad7878315bc6cc31e8118d941
Submitter: Jenkins
Branch: stable/ocata

commit b7c038380045614ad7878315bc6cc31e8118d941
Author: Michele Baldessari <email address hidden>
Date: Wed Jun 7 10:20:25 2017 +0200

Only set the stonith property on the pacemaker_master node

While this works in general it creates extra CIB changes for nothing and
slows down the deployment.

    Change-Id: Ifef08033043a4cc90a6261e962d2fdecdf275650
    Closes-Bug: #1696336
    (cherry picked from commit 332755c0fd586f0a3085704b3f4bda78ad8a87ad)