gcc7: trunk fails to compile a release build

Sorry, the error is missing in the previous attached file... here it is:

In file included from /home/kaputtnik/widelands-repo/trunk/src/network/gameclient.h:25:0,
                 from /home/kaputtnik/widelands-repo/trunk/src/network/gameclient.cc:20:
/home/kaputtnik/widelands-repo/trunk/src/logic/game_settings.h: In member function 'void GameClient::receive_one_user(uint32_t, StreamRead&)':
/home/kaputtnik/widelands-repo/trunk/src/logic/game_settings.h:52:8: error: 'newuser.UserSettings::position' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 struct UserSettings {
        ^~~~~~~~~~~~
cc1plus: some warnings being treated as errors
make[2]: *** [src/network/CMakeFiles/network.dir/build.make:111: src/network/CMakeFiles/network.dir/gameclient.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:27411: src/network/CMakeFiles/network.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

Oh, this issue is handled in https://code.launchpad.net/~widelands-dev/widelands/gcc7/+merge/323576

Indeed, there's a merge proposal for this issue. It has built successfully, but I believe GunChleoc is cleaning up some remaining issues.

It is good to have a bug report on this, so thanks for reporting. I assume it is only a matter of time before maintainers will try (or need) to rebuild Widelands with gcc7 and hopefully this branch or patch will save them duplicating too much of the work.

I think we should add the patch to the Build19 branch too when it's done - it will make life easier for packagers.

Debian (and Ubuntu) has begun rebuilding packages as part of making GCC7 the default compiler, so adding bug watches and updating to make this easier to find.

There's an updated branch for build19 https://code.launchpad.net/~widelands-dev/widelands/b19 with patches for building with GCC7 (specifically http://bazaar.launchpad.net/~widelands-dev/widelands/b19/revision/8149)

Fixed in version 1:19+repack-4 which is available on Ubuntu Artful.

Fixed in build20-rc1