reno

upgrade note missing from nova 14.0.0 release notes

Bug #1695057 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
reno
Fix Released
Undecided
Unassigned

Bug Description

Nova has this release note which went into the 14.0.0 tag for Newton:

https://github.com/openstack/nova/commit/17a8e8a68cbe4045a1bc2889d1bf51f2db7ebcca

But it doesn't show up in the rendered site:

https://docs.openstack.org/releasenotes/nova/newton.html#upgrade-notes

The hash is unique:

user@ubuntu:~/git/nova$ ls -l releasenotes/notes/ | grep b33489ed3b1b246b
-rw-rw-r-- 1 user user 749 May 31 20:47 flavors-moved-to-api-database-b33489ed3b1b246b.yaml
user@ubuntu:~/git/nova$

I see that we're not setting ":earliest-version:" in all of the reno indexes in Nova, e.g.:

https://raw.githubusercontent.com/openstack/nova/master/releasenotes/source/ocata.rst

Could that cause issues?

Revision history for this message
Matt Riedemann (mriedem) wrote :

(1:44:38 PM) dhellmann: mriedem : the issue is a8ebbebd4e merges the 13.0.0 tag into that branch and that screws up reno's scanner
(1:45:42 PM) dhellmann: at that point the scanner can't tell the difference between the mitaka and newton branches
(1:46:12 PM) dhellmann: let me see if I can teach it to ignore those
(1:46:24 PM) mriedem: oh weird https://review.openstack.org/#/c/302578/
(1:46:28 PM) mriedem: i don't even remember that thing
(1:46:53 PM) dhellmann: we used to do that so that master never had older version numbers than stable branches

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

the issue is a8ebbebd4e merges the 13.0.0 tag into that branch and that screws up reno's scanner

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to reno (master)

Reviewed: https://review.openstack.org/470023
Committed: https://git.openstack.org/cgit/openstack/reno/commit/?id=bd6fecc8587ee919eba78b9fd70a17e6a5ad510a
Submitter: Jenkins
Branch: master

commit bd6fecc8587ee919eba78b9fd70a17e6a5ad510a
Author: Doug Hellmann <email address hidden>
Date: Thu Jun 1 17:32:24 2017 -0400

    ignore null-merges

    OpenStack used to use null-merges to bring final release tags from
    stable branches back into the master branch. This confuses the regular
    traversal because it makes that stable branch appear to be part of
    master and/or the later stable branch. Update the scanner so that when
    it hit one of those merge commits, it skips it and take the first parent
    so it continues to traverse the branch being scanned.

    Change-Id: I90722a3946f691e8f58a52e68ee455d6530f047a
    Closes-Bug: #1695057
    Signed-off-by: Doug Hellmann <email address hidden>

Changed in reno:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/reno 2.4.0

This issue was fixed in the openstack/reno 2.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.