Juju Charms Collection
ceph package

ceph-mon charm incorrectly embed ntp package installation

Bug #1690513 reported by Patrizio Bassi
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph Monitor Charm
Fix Released
High
David Ames
Ceph Monitor Charm 17.08
Ceph RADOS Gateway Charm
Fix Released
High
David Ames
Ceph RADOS Gateway Charm 17.08
OpenStack Ceph Charm (Retired)
Fix Released
High
Unassigned
charms.ceph
Fix Released
High
David Ames
ceph (Juju Charms Collection)
Invalid
Undecided
Unassigned

Bug Description

as in https://github.com/openstack/charm-ceph-mon/blob/733bad44f2689b2bdf61847d21a0e0109c2a4438/lib/ceph/__init__.py#L76

ntp is a mandatory dependency in ceph-mon charm.
This is not needed, expecially when deployed in a lxc container, but even on bare metal it may mess up things set up by ntp charm relation. (i'm thinking about an openstack deployment)

Can you please evaluate if removal is safe?

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Copied the following comment from dup bug 1690514:

as in https://github.com/openstack/charm-ceph-radosgw/blob/fd401d5b95a0cda5763a44946df80c6b1951561d/hooks/hooks.py#L86

ntp is a mandatory dependency in ceph-radosgw charm.
This is not needed, expecially when deployed in a lxc container, but even on bare metal it may mess up things set up by ntp charm relation. (i'm thinking about an openstack deployment)

Can you please evaluate if removal is safe?

Changed in ceph (Juju Charms Collection):
status: New → Invalid
Revision history for this message
Patrizio Bassi (patrizio-bassi) wrote :

Why duplicate? It Is the same issue but in different charm...

Revision history for this message
James Page (james-page) wrote :

@Patrizio

We can track resolution of the same problem across multiple charms this way - each charm is a task on the bug.

David Ames (thedac)
Changed in charm-ceph-mon:
status: New → In Progress
importance: Undecided → High
assignee: nobody → David Ames (thedac)
milestone: none → 17.08
Changed in charm-ceph-radosgw:
importance: Undecided → High
status: New → Triaged
assignee: nobody → David Ames (thedac)
milestone: none → 17.08
David Ames (thedac)
Changed in charms.ceph:
status: New → In Progress
importance: Undecided → High
assignee: nobody → David Ames (thedac)
David Ames (thedac)
Changed in charms.ceph:
status: In Progress → Fix Committed
David Ames (thedac)
Changed in charm-ceph-radosgw:
status: Triaged → In Progress
Revision history for this message
David Ames (thedac) wrote :

Going through CI now
https://review.openstack.org/#/q/topic:bug/169051

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph (master)

Reviewed: https://review.openstack.org/465142
Committed: https://git.openstack.org/cgit/openstack/charm-ceph/commit/?id=04b8f8492737b429a1465e609c72174171d433ac
Submitter: Jenkins
Branch: master

commit 04b8f8492737b429a1465e609c72174171d433ac
Author: David Ames <email address hidden>
Date: Tue May 16 11:22:55 2017 -0700

    Do not install NTP when installed in a container

    Use determine_packages() to avoid installing NTP when in a container.
    Sync charms.ceph to get ceph.determine_packages().

    Change-Id: Ia00af86964d8f77e615367cbcde35a4d7d10774c
    Partial-Bug: #1690513

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-radosgw (master)

Reviewed: https://review.openstack.org/465137
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-radosgw/commit/?id=858ce946bb001ffc8068af584df21f7e2f6b148f
Submitter: Jenkins
Branch: master

commit 858ce946bb001ffc8068af584df21f7e2f6b148f
Author: David Ames <email address hidden>
Date: Tue May 16 11:11:53 2017 -0700

    Do not install NTP when installed in a container

    Check if the charm is installed inside a container and do not install
    NTP if that is the case.

    Partial-Bug: #1690513
    Change-Id: Ib290733a175197dee1261043a1e8ff2edc0b53e5

David Ames (thedac)
Changed in charm-ceph-mon:
status: In Progress → Fix Committed
Changed in charm-ceph-radosgw:
status: In Progress → Fix Committed
James Page (james-page)
Changed in charm-ceph-mon:
status: Fix Committed → Fix Released
Changed in charm-ceph-radosgw:
status: Fix Committed → Fix Released
Revision history for this message
James Page (james-page) wrote :

Marking ceph task Fix Released as this was resolved in charms.ceph, and ceph got a sync prior to the 17.08 release.

Changed in charm-ceph:
status: New → Fix Released
importance: Undecided → High
Changed in charms.ceph:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.