Evergreen

Internal Flag ingest.disable_metabib_field_entry not used

Bug #1684984 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 3.0-beta

Bug Description

Evergreen Versions 2.10 - 2.12 (probably affects earlier versions)
OpenSRF Version: N/A
PostgreSQL Version: N/A

While working on yet-another-ingest script, I noticed that the config.internal_flag ingest.disable_metabib_field_entry is not used in the biblio.indexing_ingest_or_delete function.

It looks like it should be checked before the line that does:

PERFORM metabib.reingest_metabib_field_entries(NEW.id);

If the consensus is that the setting should be checked before performing that operation, I can make a patch branch rather easily.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Following some discussion in IRC http://irc.evergreen-ils.org/evergreen/2017-04-21#i_301342

The ingest.disable_metabib_field_entry flag is apparently obsoleted by the three flags controlling search, browse, and facet indexing.

I'll make a branch to remove the flag from the table and share it shortly.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 3.0-alpha
no longer affects: evergreen/3.0
Changed in evergreen:
milestone: 3.0-alpha → none
Jason Stephenson (jstephenson)
Changed in evergreen:
milestone: none → 3.next
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Branch with pgtap test pushed to working/user/dyrcona/lp1684984-remove-ingest.disable_metabib_field_entry

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1684984-remove-ingest.disable_metabib_field_entry

Not sure if this needs a release note or not.

tags: added: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I added a release note in a second commit. Feel free to squash it into the previous commit if that makes review/pushing easier.

Revision history for this message
Galen Charlton (gmc) wrote :

Tested and signed off. Branch is user/gmcharlt/lp1684984_signoff.

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master. Thanks, Jason!

Changed in evergreen:
status: Confirmed → Fix Committed
Revision history for this message
Ben Shum (bshum) wrote :

assigning to correct milestone

Changed in evergreen:
milestone: 3.next → 3.0-alpha
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.