ocf_log function improperly called in mysql-wss ocf resource

Bug #1683647 reported by Lukasz Pelczyk
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
In Progress
Medium
Gabor Orosz
Nominated for Ocata by Oleksiy Molchanov
Mitaka
Confirmed
Medium
Oleksiy Molchanov
Newton
Confirmed
Medium
Oleksiy Molchanov

Bug Description

Identified on Fuel 9.2, probably affects older releases.
Priority: Low - corosync logs are being spammed by warnings regarding improperly called function.

Root cause: /usr/lib/ocf/resource.d/fuel/mysql-wss - function ocf_log. Few times this function is called without "log-level/severity" parameter, e.g.:

nodes_in_cluster_online() {
    local LH="${LL} nodes_in_cluster_online():"
    local NODES

    NODES=$(crm_node --partition | sed -e '/(null)/d')
    if [ ! -z "$NODES" ]; then
        ocf_log "${LH} Online Nodes in cluster: ${NODES}" # <= One parameter only, should be two
        echo $NODES
    else
        ocf_log "${LH} No online nodes in cluster" # <= One parameter only, should be two
        echo
    fi
}

Later in same file are also proper calls, e.g.:
    if [ -z $1 ]; then
        ocf_log $status_loglevel "${LH} No GTID provided"
        return 1
    fi

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/457520

Changed in fuel:
assignee: nobody → Oleksiy Molchanov (omolchanov)
status: New → In Progress
Changed in fuel:
milestone: none → 11.x-updates
importance: Undecided → Medium
Revision history for this message
Javier Diaz Jr (javierdiazcharles) wrote :

Hello team,

We have a customer facing this bug and is requesting an update on the release of this patch. Can we expect this to be released for MOS 9.2 MU2?

Changed in fuel:
assignee: Oleksiy Molchanov (omolchanov) → Gabor Orosz (gabor.orosz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/430931
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: master
Review: https://review.opendev.org/457520
Reason: This repo is retired now, no further work will get merged.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.