Remove traces of JWT login

Bug #1682917 reported by Paul Everitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL4
Fix Released
Low
Jim Fulton

Bug Description

In my failed attempt to make a rich frontend, I asked Carlos over a year ago to give my a JWT-based login. This meant:

- Some views that processed credentials and returned a JWT token
- A series of dependencies: wsgicors, pyramid_jwt, cryptography, etc.

Let's back out of all of that. Go back and find the commits to see what was brought in. It would be very nice to not have those dependencies (and that security method) still around.

Revision history for this message
Paul Everitt (paul-agendaless) wrote :
Changed in karl4:
assignee: Carlos de la Guardia (cguardia) → Paul Everitt (paul-agendaless)
Changed in karl4:
assignee: Paul Everitt (paul-agendaless) → Jim Fulton (jim-zope)
Revision history for this message
Jim Fulton (jim-zope) wrote :

Was this ever used? I just grepped /api/login in prod logs from August and didn't get any hits, so I assume not.

Revision history for this message
Jim Fulton (jim-zope) wrote :

(I grepped current prod logs as well).

Revision history for this message
Jim Fulton (jim-zope) wrote :

I assume you're use that ripping out jwt isn't going to break the rest of login. :) If I can log in on stage, is that a sufficient test?

Revision history for this message
Paul Everitt (paul-agendaless) wrote : Re: [Bug 1682917] Remove traces of JWT login

Yep, it’s sufficient. We’ll have Nat kick in various weird ways as well.

—Paul

> On May 30, 2017, at 4:29 PM, Jim Fulton <email address hidden> wrote:
>
> I assume you're use that ripping out jwt isn't going to break the rest
> of login. :) If I can log in on stage, is that a sufficient test?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1682917
>
> Title:
> Remove traces of JWT login
>
> Status in KARL4:
> New
>
> Bug description:
> In my failed attempt to make a rich frontend, I asked Carlos over a
> year ago to give my a JWT-based login. This meant:
>
> - Some views that processed credentials and returned a JWT token
> - A series of dependencies: wsgicors, pyramid_jwt, cryptography, etc.
>
> Let's back out of all of that. Go back and find the commits to see
> what was brought in. It would be very nice to not have those
> dependencies (and that security method) still around.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl4/+bug/1682917/+subscriptions

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

It was used on an Angular admin front end I was stupidly working on, which is now removed.

—Paul

> On May 30, 2017, at 4:16 PM, Jim Fulton <email address hidden> wrote:
>
> Was this ever used? I just grepped /api/login in prod logs from August
> and didn't get any hits, so I assume not.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1682917
>
> Title:
> Remove traces of JWT login
>
> Status in KARL4:
> New
>
> Bug description:
> In my failed attempt to make a rich frontend, I asked Carlos over a
> year ago to give my a JWT-based login. This meant:
>
> - Some views that processed credentials and returned a JWT token
> - A series of dependencies: wsgicors, pyramid_jwt, cryptography, etc.
>
> Let's back out of all of that. Go back and find the commits to see
> what was brought in. It would be very nice to not have those
> dependencies (and that security method) still around.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl4/+bug/1682917/+subscriptions

Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Jim, I think this was done and released, right?

Changed in karl4:
status: New → In Progress
milestone: 031 → 032
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

I'm going to mark this as done and released.

Changed in karl4:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.