upgrade angular-ui-bootstrap to at least 1.3.3
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
We're currently using 1.2.4 of angular-
Here are the list of potentially relevant breaking changes gleaned from the release notes between 1.2.4 and 1.3.3:
* timepicker: This removes automatic padding done by the timepicker when the input is empty - if that behavior is desired, write a custom directive implementing it
* dropdown: The dropdown no longer will remain open on $locationChange
* datepickerPopup: The datepicker popup is no longer a part of the datepicker module, but now a part of the datepickerPopup module. Please change code accordingly if including specific modules
* datepicker: This removes inline datepicker attribute support and attribute pass-throughs in the popup
* dropdown: Stops propagation of keydown event when escape key is pressed. Removes keydown event from the document and moves it to the dropdown element.
* modal: Since this adds support for $resolve being exposed on $scope, it could potentially overwrite any pre-existing usage of it - this is an unlikely scenario, but marked as a breaking change in case this key is being used
As far as I can tell, there's major nothing stopping us from going past 1.3.3 and up to 2.5.0+, just a lot more breaking changes to double-check.
Evergreen master
A patch for this is included in the branch for the web staff client's serial module; please see bug 1708291.