[2.2] Edited notifications reappear to users who have dismissed them and cannot be dismissed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Mike Pontillo |
Bug Description
Steps to reproduce:
Use the branch at: lp:~mpontillo/maas/iprange-notifications--bug-1393936
(if it has not already been merged[1])
- Create a large IP range sufficient to cover the subnet and cause an IP exhaustion warning
- Dismiss the notification
- Save any IP address or edit or delete any IP address associated with the same subnet
Expected behavior: no notification reappears, since it has been dismissed for that subnet.
Actual behavior: notification appears, but cannot be dismissed.
---
Triage found that when the notification text changes, the trigger notices and send an event to the websocket handler. This causes a notification to be sent to the UI, and the dismissed event is "resurrected". However, dismissing it again is a no-op, since it has already been dismissed.
---
[1]:
https:/
Related branches
- Andres Rodriguez (community): Approve
-
Diff: 38 lines (+17/-0)2 files modifiedsrc/maasserver/websockets/handlers/notification.py (+4/-0)
src/maasserver/websockets/handlers/tests/test_notification.py (+13/-0)
Changed in maas: | |
milestone: | none → 2.2.0rc2 |
summary: |
- [2.2] Edited notifications reappear to users who have dismissed them + [2.2] Edited notifications reappear to users who have dismissed them and + cannot be dismissed |
description: | updated |
Changed in maas: | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Gavin Panella (allenap) |
description: | updated |
Changed in maas: | |
milestone: | 2.2.0rc2 → 2.2.0rc3 |
assignee: | Gavin Panella (allenap) → nobody |
Changed in maas: | |
assignee: | nobody → Mike Pontillo (mpontillo) |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |