Mir

mir_window_spec_set_cursor_render_surface does not work

Bug #1679836 reported by Alberto Aguirre
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Alberto Aguirre
Mir 0.27.0

Bug Description

To set a custom cursor, mir_window_spec_set_cursor_render_surface can be used, but currently does not work.

Related branches

lp://staging/~albaguirre/mir/fix-1679836
Mir CI Bot: Approve (continuous-integration)
Brandon Schaefer (community): Approve
Diff: 83 lines (+36/-8)
3 files modified
src/server/frontend/session_mediator.cpp (+3/-8)
tests/acceptance-tests/test_client_cursor_api.cpp (+31/-0)
tests/include/mir/test/doubles/mock_buffer_stream.h (+2/-0)
lp://staging/~alan-griffiths/mir/cherrypicking-0.27
lp://staging/~ci-train-bot/mir/mir-ubuntu-zesty-2683
lp://staging/~ci-train-bot/mir/mir-ubuntu-artful-2806
lp://staging/~ci-train-bot/mir/mir-ubuntu-zesty-2818
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

There's no acceptance tests associated with mir_window_spec_set_cursor_render_surface.

The root cause is mf::SessionMediator::modify_surface should call stream->suitable_for_cursor instead of trying to check the pixel format itself.

Changed in mir:
milestone: none → 0.28.0
assignee: nobody → Alberto Aguirre (albaguirre)
importance: Undecided → High
status: New → In Progress
Daniel van Vugt (vanvugt)
tags: added: clientapi cursor
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.28.0

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: 0.28.0 → 0.27.0
no longer affects: mir/0.27
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.