widelands

END OF EXPEDITION due to time-out schip.cc assertion failed

Bug #1678598 reported by Klaus Halfmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Critical
Unassigned
widelands build20-rc1

Bug Description

I played "The Nile" and conquere a (the last) castle for player 1, blue at 11,96
I continued playing for about 5 minutes. then I got:

5: Azurea Sea at 100x 98: END OF EXPEDITION due to time-out
Assertion failed: (get_economy() && get_economy() != expedition_->economy.get()), function exp_cancel, file /Users/klaus/develop/widelands-repo/widelands/src/logic/map_objects/tribes/ship.cc, line 923.

I would assume that the poor ship had no owner and no economy any longer.

Suggestions: such a ship should eihter destory itself on continue its expeditions
(Unless there are no more port spaces).

Related branches

lp://staging/~widelands-dev/widelands/bug-1678598-expedition-no-eco-crash
Klaus Halfmann: Approve (code revie, compile, test)
Diff: 839 lines (+120/-52)
42 files modified
src/ai/defaultai_seafaring.cc (+10/-0)
src/economy/flag.cc (+2/-1)
src/economy/flag.h (+1/-1)
src/economy/fleet.cc (+10/-3)
src/economy/fleet.h (+2/-1)
src/economy/portdock.cc (+2/-1)
src/economy/portdock.h (+1/-1)
src/economy/road.cc (+2/-1)
src/economy/road.h (+1/-1)
src/economy/ware_instance.cc (+2/-2)
src/economy/ware_instance.h (+1/-1)
src/logic/map_objects/bob.cc (+2/-1)
src/logic/map_objects/bob.h (+1/-1)
src/logic/map_objects/immovable.cc (+4/-3)
src/logic/map_objects/immovable.h (+2/-2)
src/logic/map_objects/map_object.cc (+2/-1)
src/logic/map_objects/map_object.h (+1/-1)
src/logic/map_objects/tribes/battle.cc (+2/-1)
src/logic/map_objects/tribes/battle.h (+1/-1)
src/logic/map_objects/tribes/building.cc (+2/-1)
src/logic/map_objects/tribes/building.h (+1/-1)
src/logic/map_objects/tribes/constructionsite.cc (+2/-1)
src/logic/map_objects/tribes/constructionsite.h (+1/-1)
src/logic/map_objects/tribes/dismantlesite.cc (+2/-1)
src/logic/map_objects/tribes/dismantlesite.h (+1/-1)
src/logic/map_objects/tribes/militarysite.cc (+2/-1)
src/logic/map_objects/tribes/militarysite.h (+1/-1)
src/logic/map_objects/tribes/partially_finished_building.cc (+2/-1)
src/logic/map_objects/tribes/partially_finished_building.h (+1/-1)
src/logic/map_objects/tribes/productionsite.cc (+2/-1)
src/logic/map_objects/tribes/productionsite.h (+1/-1)
src/logic/map_objects/tribes/ship.cc (+23/-4)
src/logic/map_objects/tribes/ship.h (+3/-3)
src/logic/map_objects/tribes/soldier.cc (+2/-2)
src/logic/map_objects/tribes/soldier.h (+1/-1)
src/logic/map_objects/tribes/trainingsite.cc (+2/-1)
src/logic/map_objects/tribes/trainingsite.h (+1/-1)
src/logic/map_objects/tribes/warehouse.cc (+2/-1)
src/logic/map_objects/tribes/warehouse.h (+1/-1)
src/logic/map_objects/tribes/worker.cc (+2/-1)
src/logic/map_objects/tribes/worker.h (+1/-1)
src/wui/shipwindow.cc (+15/-0)
Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :
Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :
Revision history for this message
Klaus Halfmann (klaus-halfmann) wrote :

After loading this second file I must wait unil 11:41 and the got the crash,
can someone confirm?

Hans Joachim Desserud (hjd)
tags: added: crash economy seafaring
Revision history for this message
Notabilis (notabilis27) wrote :

Crashes after a few seconds for me, too. But took me some time to figure out that it is a multiplayer game, so of course it doesn't appear in the single player load screen. ;-)

The assertion fails since get_economy() returns a null pointer. A backtrace is attached.

Revision history for this message
Notabilis (notabilis27) wrote :

A simple fix seems to be:
 if (get_economy() == nullptr) {
  sink_ship(game);
  return;
 }
in front of the assertion (src/logic/map_objects/tribes/ship.cc:923).
At least, it doesn't crashes any longer. But I haven't really read the code, and I guess some digging should be done why the economy is null anyway.

GunChleoc (gunchleoc)
Changed in widelands:
status: New → Triaged
milestone: none → build20-rc1
importance: Undecided → Critical
Revision history for this message
GunChleoc (gunchleoc) wrote :

What happens is that grey player has lost their port, so there is no port to return to for the canceled expedition. So, I'd suggest (pseudocode):

if (get_economy() == nullptr) {
  if (has_other_reachable_portdock()) {
    add_ship_to_reachable_portdocks_fleet();
  } else {
    return;
  }
}

do_cancel_expedition;

GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
Revision history for this message
GunChleoc (gunchleoc) wrote :

Singleplayer savegame with 2 ports and 2 expeditions for further testing.

Revision history for this message
GunChleoc (gunchleoc) wrote :

The code already looks for a reachable port dock, so the final fix is:

If no reachable port dock found:
- Reset Expedition state
- Warning dialog shown to owning player
- AI continues exploring

Changed in widelands:
status: Triaged → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.