OpenStack Dashboard (Horizon)

operation_log: mask_fields are always recorded even if it is not contained in user parameters

Bug #1675191 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki
OpenStack Dashboard (Horizon) pike-1

Bug Description

operation_log middlware always output mask_fields even when they are not included in a user parameters. It is really confusing.

horizon/middleware/operation_log.py

        for key in params.items():
            # replace a value to a masked characters
            for key in self.mask_fields: <----- This should be 'if'.....
                params[key] = '*' * 8

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/448799

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/448799
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d04f164ab2d2472e181226201a68feaaf1454450
Submitter: Jenkins
Branch: master

commit d04f164ab2d2472e181226201a68feaaf1454450
Author: Akihiro Motoki <email address hidden>
Date: Wed Mar 22 21:41:50 2017 +0000

    operation_log: Log mask_fields only when exists in request

    Previously mask_fields are always output even when they are
    not included in a user request. It is confusing.

    Change-Id: Ia207bfbc61246bc722a2ced544a8955f52025c0c
    Closes-Bug: #1675191

Changed in horizon:
status: In Progress → Fix Released
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
milestone: none → pike-1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.opendev.org/701903

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/ocata)

Reviewed: https://review.opendev.org/701903
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ceb93c2fdd5192dd6480285b8d8171c640b7d893
Submitter: Zuul
Branch: stable/ocata

commit ceb93c2fdd5192dd6480285b8d8171c640b7d893
Author: Akihiro Motoki <email address hidden>
Date: Wed Mar 22 21:41:50 2017 +0000

    operation_log: Log mask_fields only when exists in request

    Previously mask_fields are always output even when they are
    not included in a user request. It is confusing.

    Change-Id: Ia207bfbc61246bc722a2ced544a8955f52025c0c
    Closes-Bug: #1675191
    (cherry picked from commit d04f164ab2d2472e181226201a68feaaf1454450)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon ocata-eol

This issue was fixed in the openstack/horizon ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.