[regression] Mixing screen rotation with mode changes makes the image squished
Bug #1672269 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Daniel van Vugt | ||
0.26 |
Invalid
|
Undecided
|
Unassigned | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[regression] Mixing screen rotation with mode changes makes the image squished
This problem is visible in lp:mir but not in Mir 0.26 (zesty):
1. Start a client
2. Move the client to the top left of the screen.
3. Rotate right (mirout rotate right)
3. Lower the resolution (mirout mode 720x400)
Expected: Rendering stays in correct proportions
Observed: Rendering is squished out of proportion.
Related branches
lp://staging/~vanvugt/mir/fix-1672269
- Mir CI Bot: Approve (continuous-integration)
- Alan Griffiths: Approve
- Alexandros Frantzis (community): Approve
-
Diff: 111 lines (+65/-1)3 files modifiedsrc/renderers/gl/renderer.cpp (+12/-1)
src/renderers/gl/renderer.h (+2/-0)
tests/unit-tests/renderers/gl/test_gl_renderer.cpp (+51/-0)
Changed in mir: | |
status: | Triaged → In Progress |
Changed in mir (Ubuntu): | |
status: | New → Invalid |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Predictably it seems r4035 caused this. Although curiously there is only a problem if you rotate before changing modes and not vice-versa...
------- ------- ------- ------- ------- ------- ------- ------- ----
revno: 4035 [merge]
author: Daniel van Vugt <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Thu 2017-02-16 04:47:36 +0000
message:
Add letterboxing/black bars support to the GL renderer, for when
the logical viewport aspect doesn't match that of the screen.
This will be used in future for arbitrary cloning of one monitor /bugs.launchpad .net/bugs/ 1639226.
to another (LP: #1639226)
. Fixes: https:/
Approved by Brandon Schaefer, mir-ci-bot. ------- ------- ------- ------- ------- ------- ------- ----
-------