tripleo

Fencing generation fails if there are unprovisioned nodes

Bug #1671881 reported by Chris Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Chris Jones
tripleo pike-1 "pike-1"

Bug Description

If Ironic knows about more nodes than the ones which have been deployed in Nova, the instackenv.json file will contain more nodes than are in the fencing generator's hostmap, which causes the mistral action to crash:

2017-03-10 11:46:22.537 1642 ERROR mistral.engine.default_executor Traceback (most recent call last):
2017-03-10 11:46:22.537 1642 ERROR mistral.engine.default_executor File "/usr/lib/python2.7/site-packages/mistral/engine/default_executor.py", line 89, in run_action
2017-03-10 11:46:22.537 1642 ERROR mistral.engine.default_executor result = action.run()
2017-03-10 11:46:22.537 1642 ERROR mistral.engine.default_executor File "/usr/lib/python2.7/site-packages/tripleo_common/actions/parameters.py", line 279, in run
2017-03-10 11:46:22.537 1642 ERROR mistral.engine.default_executor params["pcmk_host_list"] = hostmap[mac_addr]["compute_name"]
2017-03-10 11:46:22.537 1642 ERROR mistral.engine.default_executor KeyError: u'aa:bb:cc:dd:ee:ff'
2017-03-10 11:46:22.537 1642 ERROR mistral.engine.default_executor

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/444419

Changed in tripleo:
status: Confirmed → In Progress
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: none → pike-1
tags: added: ocata-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/444419
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c4b04bbd6ac2a8a4d3bb7ece4f8a0b4cecdd020c
Submitter: Jenkins
Branch: master

commit c4b04bbd6ac2a8a4d3bb7ece4f8a0b4cecdd020c
Author: Chris Jones <email address hidden>
Date: Fri Mar 10 17:06:26 2017 +0000

    Handle unprovisioned Ironic nodes in fencing parameter generator.

    We now ignore nodes that are defined in Ironic, but which have not been
    used as part of an overcloud deployment, rather than crashing.

    Change-Id: I1d4d9b510895cfae3b7914d6d6d6778ba1bdc180
    Closes-Bug: #1671881

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/445570

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/450199

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/ocata)

Reviewed: https://review.openstack.org/445570
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=49ca8f33783b0b78ed6d66ea5d82836beb38ff1c
Submitter: Jenkins
Branch: stable/ocata

commit 49ca8f33783b0b78ed6d66ea5d82836beb38ff1c
Author: Chris Jones <email address hidden>
Date: Fri Mar 10 17:06:26 2017 +0000

    Handle unprovisioned Ironic nodes in fencing parameter generator.

    We now ignore nodes that are defined in Ironic, but which have not been
    used as part of an overcloud deployment, rather than crashing.

    Change-Id: I1d4d9b510895cfae3b7914d6d6d6778ba1bdc180
    Closes-Bug: #1671881
    (cherry picked from commit c4b04bbd6ac2a8a4d3bb7ece4f8a0b4cecdd020c)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/450199
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5df7d9249e8227a66829b8edeafdd342423e3b87
Submitter: Jenkins
Branch: master

commit 5df7d9249e8227a66829b8edeafdd342423e3b87
Author: Chris Jones <email address hidden>
Date: Mon Mar 27 13:49:37 2017 +0100

    Extend testing for GenerateFencingParamatersAction.

    We now test that unprovisioned Ironic nodes are ignored by the fencing
    parameters generator.

    This commit adds testing for a bug fixed in
      c4b04bbd6ac2a8a4d3bb7ece4f8a0b4cecdd020c

    Change-Id: Ie55e44657c90e2fd1cf3bfed4dcb3fd932f5eadf
    Related-Bug: #1671881

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.0.0.0b1

This issue was fixed in the openstack/tripleo-common 7.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 6.1.0

This issue was fixed in the openstack/tripleo-common 6.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.