Evergreen

OPAC hold request form should not default to an SMS carrier

Bug #1669534 reported by Chris Sharp
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 3.0-beta
2.12
Fix Released
Medium
Unassigned
Evergreen 2.12.5

Bug Description

When a user without a "opac.default_sms_carrier" ("Default SMS/Text Carrier") setting places a hold request, they can then enter their SMS number and select their SMS carrier. However, the carrier selection dropdown list defaults to the first carrier on the list, which means that if a user doesn't actively select their carrier, the resulting notification will go to an incorrect email address. The dropdown list should default to "blank" or "--" and the Submit button should be inactive until the user selects an SMS carrier.

Evergreen 2.11.1 (probably all TPAC versions with SMS enabled, though)
OpenSRF 2.4.1
PostgreSQL 9.4
Ubuntu 14.04 LTS

Chris Sharp (chrissharp123)
Changed in evergreen:
importance: Low → Medium
Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
assignee: nobody → Cesar V (cesardv)
Revision history for this message
Michele Morgan (mmorgan) wrote :

Adding a link to related bug 1098685

Revision history for this message
Cesar V (cesardv) wrote :

See related bug 1098685 for fix branches

tags: added: pullrequest
Changed in evergreen:
assignee: Cesar V (cesardv) → nobody
Cesar V (cesardv)
tags: added: needstest
Jason Etheridge (phasefx)
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
milestone: none → 3.0-alpha
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Signoff branch for this fix is here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/1669534_opac_should_not_default_to_sms_carrier

I had trouble getting the other fix in that branch working (see bug 1098685 for further comments), so for now I'm just signing off on the commit that fixes this bug.

tags: added: signedoff
Chris Sharp (chrissharp123)
Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_2_12. Thanks, Cesar and Chris!

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.