Mudlet

Default packages are no longer installed on new profiles (temporary post-iota only)

Bug #1668177 reported by Vadim Peretokin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mudlet
Fix Released
Critical
Stephen Lyons
Mudlet 3.0.0

Bug Description

Default packages are no longer installed on new profiles - WoTMUD does not install anything at all (not the lua, echo, or deleteOldProfiles alias) and Lusternia literally only installs 1 timer from the mudlet-mapper package...

This works fine in 2.1, and it is a seriously massive regression because upgrading Mudlet will not fix all the profiles that got created without these vital scripts that a lot of instructions depend upon and users will expect to see.

Revision history for this message
Stephen Lyons (slysven) wrote :

This will also affect your recent addition of, was it Black Sun 2?

**Condition Red** I'll stop my other development task and get right on this!

Do we have any indication from a git bisect or other means where this was introduced - I suspect there are some obvious candidates and is it on both development and/or release_30?

Changed in mudlet:
assignee: nobody → Stephen Lyons (slysven)
Revision history for this message
Stephen Lyons (slysven) wrote :

Confirm! Only in the release_30 branch of code (https://github.com/Mudlet/Mudlet/commit/32d7afdb5052b6771ef8719fd96ffbf6107a7b73) and not development (https://github.com/Mudlet/Mudlet/commit/32d7afdb5052b6771ef8719fd96ffbf6107a7b73ee32cfb66e1e0a07f321544b9b88490c66444447) as of 2017/02/28T22:45:00Z...

Changed in mudlet:
status: New → Confirmed
Revision history for this message
Stephen Lyons (slysven) wrote :

Oh a typo in the above - the development commit WITHOUT the issue was:
https://github.com/Mudlet/Mudlet/commit/ee32cfb66e1e0a07f321544b9b88490c66444447 !

Stephen Lyons (slysven)
Changed in mudlet:
status: Confirmed → In Progress
Revision history for this message
Stephen Lyons (slysven) wrote :

Found the problem, in reformatting code layout in conjunction with applying clang-format tool to XMLimport class I was manually inserting '{' ... '}' around single line code blocks for if/else constructs and mis-read the code structure so that a nested else code block got nested with the wrong if(...)

Just running up a fix PR...

Incidentally whilst investigating and comparing the release_30 and development branches I discovered another error in the development branch that would affect at least MSVC builds on Windows platform, will address that as well.

Revision history for this message
Stephen Lyons (slysven) wrote :

PRs ready as https://github.com/Mudlet/Mudlet/pull/396 for this bug on release_30 branch {and https://github.com/Mudlet/Mudlet/pull/395 for the different issue for the development branch{.

Vadim Peretokin (vperetokin)
Changed in mudlet:
status: In Progress → Fix Committed
summary: - Default packages are no longer installed on new profiles
+ Default packages are no longer installed on new profiles (temporary
+ post-iota only)
Vadim Peretokin (vperetokin)
Changed in mudlet:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.