[unity8] It's impossible to close some dialogs (missing 'X' window button)

I'm not sure but AFAIK Mir does not yet have the sufficient client API for child windows to specify whether they support close/minimize/maximize (which is independent information from the window type). It's possible we're trying to guess the right feature set right now.

Status changed to 'Confirmed' because the bug affects multiple users.

Incomplete for Mir. I'm not sure but we may still be lacking sufficient client API in Mir to specify what buttons to show (and to grey out)

Qt apps are not required to have any Close button as part of the dialog UI, even the standard builtin ones like Print Preview (http://doc.qt.io/qt-5/qprintpreviewdialog.html).

We need a way to close such a window (dialog), without resorting to fixing hundreds of apps themselves.

We might need to change what we map a surface like that to. Maybe in Mir case it needs to be a normal window, not a dialog?

From my perspective it is incorrect to say 'impossible to close "Print Preview" window' I can run kate in miral-shell, open the print-preview and close it (Alt-F4) fine.

Now I do agree it seems daft that there's neither a "Close" button (or equivalent) on the window, nor an "X" in the titlebar, but isn't that down to a design issue?

Just realized we have the same issue with the maximize button. If the window/dialog is resizeable (and it is in this specific case), we should display that in the decoration too.

Sure, when this window stops being a dialog, it will get it.

No, I really mean every dialog (e.g. Open File dialog), those that are resizable should get a maximize button imho, just like under u7

Assuming that maximizing it will not exceed max size, yes.

Window types generally have nothing to do with which window buttons should be visible. Window type dictates if there is a titlebar, and if so then...

Close button: Must always be visible because apps exist which have no other way of closing their windows.

Maximize button: Should only be visible for a window whose resize constraints allow it to be maximized.

Minimize button: Almost always visible, unless the window is modal to its parent.

That's not what the Mir Surfaces document dictates.

I know, but we've been confused by thinking that's a Mir/Unity8 design document. The parts about good dialog design really describe how to build a good toolkit (qtubuntu), and how to build a good shell assuming that's the only toolkit you need to support.

Legacy apps exist that require the shell must provide a close button on the dialog. There's no getting around it. Users are just going to keep reporting this bug until we fix it.

This bug was fixed in the package unity8 - 8.15+17.04.20170404.7-0ubuntu2

---------------
unity8 (8.15+17.04.20170404.7-0ubuntu2) zesty; urgency=medium

  [ Michael Zanetti ]
  * Make the default store uri point to gnome software center

 -- Timo Jyrinki <email address hidden> Thu, 06 Apr 2017 10:49:29 +0300