Evergreen

Missing billing types in upgraded systems

Bug #1666512 reported by Chris Sharp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 3.0.1
2.12
Fix Released
Low
Unassigned
Evergreen 2.12.7

Bug Description

A long time ago in a library development shop far, far away, some business logic was added to accommodate automatic billing for marking an item damaged:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2a87597

A couple of weeks after that, a feature for adding a notification fee:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c0c60f4

Unfortunately, none of the billing types added to accommodate these features made it into upgrade scripts. In fact, they pre-dated the numbered upgrade scripts by about 6 months, so we're talking ancient history here. Anyhoo, if you're one of the grizzled old systems that would have upgraded from 1.2-ish to 1.4-ish (c. first half of 2009), you may be missing them too.

Branch on the way.

Revision history for this message
Chris Sharp (chrissharp123) wrote :

Branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1666512_missing_billing_types_from_upgraded_systems

Changed in evergreen:
importance: Undecided → Low
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.next
milestone: 2.next → 2.11.4
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.11.4 → 2.11.5
Revision history for this message
Galen Charlton (gmc) wrote :

For the sake of making this a fire-and-forget upgrade step, I suggest tweaking it so that it follows the INSERT INTO ... SELECT FROM ... WHERE NOT EXISTS pattern from (e.g.) 1000.data.add-spanish-to-i18n-locale.sql .

Revision history for this message
Galen Charlton (gmc) wrote :

Strengthening my comment of last month and turning it into a needsrepatch.

tags: added: needsrepatch
removed: pullrequest
Changed in evergreen:
status: New → Confirmed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.11.5 → 2.11.6
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.11.6 → 2.11.7
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.11.7 → 2.11.8
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.11.8 → 2.11.9
Revision history for this message
Ben Shum (bshum) wrote :

Rebased to current master, signed off on csharp's original commit and added a new repatched commit version on top of it in the style requested to avoid unnecessary INSERT failures.

See top two commits in branch: user/bshum/lp1666512_repatch

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1666512_repatch

tags: added: pull
removed: needsrepatch
tags: added: pullrequest
removed: pull
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 2.11.9 → 3.0-beta2
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.0-beta2 → 3.0-rc
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.0-rc → 3.0.1
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Oops! I totally dropped this after fixing it locally.

My signoff of Ben's repatch is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1666512_repatch_signoff

tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_0, and rel_2_12. Thanks, Chris and Ben!

Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.