Web Client: Items Out does not include Long Overdue items

A fix for this is on user/cesardv/lp1665115_longoverdue_itemsout_count

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1665115_longoverdue_itemsout_count

Cesar, I think what we need here is for Long Overdue items to always be included in the sidebar Items Out tally, regardless of the Long Overdue setting referenced. So, basically, keep the stats.checkouts.total_out += Number(stats.checkouts.long_overdue); but lose the if (!egCore.env.aous['ui.circ.items_out.longoverdue'])

For reference, the XUL client does this for its running total in the summary sidebar:

robj.out
+ robj.overdue
+ (do_not_tally_claims_returned ? 0 : robj.claims_returned)
+ robj.long_overdue
+ (do_tally_lost ? robj.lost : 0)

Though it's using open-ils.actor.user.checked_out.count.authoritative more directly instead of open-ils.actor.user.opac.vital_stats.authoritative (which also calls the same method).

hrmm, but see LP1440148

Okay, so the XUL client definitely includes long overdue in all total checkout tallies, whether the long overdue xact is showing up in an Items Out list or not (based on a library setting). But in the OPAC, My Account, long overdue was removed from patron-visible tallies (and I guess is not listed in checked out lists). The web staff client is using this same API for its data.

IMO, at least to staff, long overdue items should be presented as being "out", but I'm not sure. I'm also not sure why it was removed from the patron view. In my contrived test data, in My Account, I see my long overdue item as accruing fines, but it's not listed as being checked out. It's just showing up in the fines section.

What do folks think?

I guess when an item normally becomes long overdue, it stops accruing fines. I can understand how it might be deemed to no longer be circulating... :( Still not a fan. What do we want to see here?

Hi Jason,

I agree with you that the ui.circ.items_out.longoverdue is unrelated to the Items Out tally. For Lost and Claims Returned, we have distinct settings to determine whether they should be included in the lump sum tallies. We don't have a similar setting for long overdue, possibly because sites using Long Overdue checkouts have been happy with the current behavior?

I would go with adding long overdue to the Items Out tally in all circumstances. If people do want a setting, then I think it should be a new lump sum tally setting to make it consistent with how we handle Lost and Claims Returned. But that would be a new feature, not a bug fix.

I also think Long Overdue should display in the patron account too, but I suppose that's a separate issue that should be addressed through bug 1463907.

Thanks Kathy!

I second everything Kathy said.

Jason, I've (force) updated the original branch I pushed. Can you check it out?

Cesar, looks to good me, thanks! Pushed signed commit to collab/phasefx/webstaff-bugs

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=305b4396c5252769897fce3494769fc63cb6a2f0

Works for me. Thank you Cesar and Jason! Merged to master and release 2.12