Ships can have multiple windows
Bug #1663490 reported by
GunChleoc
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
Every time you click on a ship, a new window is opened, even if there is one open already. If multiple windows are open and the ship is sunk, Widelands will segfault.
Related branches
lp://staging/~widelands-dev/widelands/bug-1663490-ship-windows
- GunChleoc: Approve
- Notabilis: Needs Resubmitting
-
Diff: 79 lines (+16/-6)4 files modifiedsrc/ui_basic/unique_window.cc (+4/-0)
src/wui/interactive_gamebase.cc (+7/-1)
src/wui/shipwindow.cc (+2/-2)
src/wui/shipwindow.h (+3/-3)
Revision history for this message
| Notabilis (notabilis27) wrote | #1 |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
| Changed in widelands: | |
| assignee: | nobody → Notabilis (notabilis27) |
| status: | New → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | Notabilis (notabilis27) → nobody |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I can reproduce the part with the multiple windows and I agree that only one should be opened. But I can't reproduce the crash in trunk r8279. Any hints or save games how to do so?