OpenStack Dashboard (Horizon)

Lack of some methods calling information in OpenStack Profiler page

Bug #1660449 reported by Lingxian Kong on 2017-01-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Richard Jones	OpenStack Dashboard (Horizon) pike-1

Bug Description

Branch: ocata
Only changed keystone configuration in local_settings.py, configuration for profiler_settings:

OPENSTACK_PROFILER.update({
    'enabled': True,
    'keys': ['SECRET_KEY'],
    'notifier_connection_string': 'mongodb://192.168.200.50:27017',
    'receiver_connection_string': 'mongodb://192.168.200.50:27017'
})

The MongoDB works fine.

After enabling 'OpenStack Profiler', I clicked 'Access & Security' panel, the total time that chrome told me was a big different with what i saw in the profiler page. i checked the code, some methods with 'profiler.trace' decorator are not included in the profiler page, e.g. tenant_quota_usages. an example is here: http://pasteboard.co/sr4VFgkSK.png

Tags:

Richard Jones (r1chardj0n3s) on 2017-01-30

Changed in horizon:
status:	New → Triaged
importance:	Undecided → Medium
milestone:	none → ocata-rc1

Revision history for this message

Richard Jones (r1chardj0n3s) wrote on 2017-01-31:

I instrumented the profiler notifies and all the profile.trace() appear to be honored, but when I look at the notifies the IndexView trace (which appears to be at the root of the trace tree) stops well before all of the requests tagged with the same base id happen - and the display in the Profiler panel stops showing calls at the same point. I don't know why:

1. the IndexView trace stops at that point, or
2. why the profiler display doesn't show *all* the traces with the same base id.

Revision history for this message

Richard Jones (r1chardj0n3s) wrote on 2017-01-31:

Not sure why IndexView stops at that point, but I know why the display doesn't show all the traces, and I believe that's good enough to resolve this bug. Patch incoming.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-31: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/426984

Changed in horizon:
assignee:	nobody → Richard Jones (r1chardj0n3s)
status:	Triaged → In Progress

Richard Jones (r1chardj0n3s) on 2017-02-02

Changed in horizon:
milestone:	ocata-rc1 → next
tags:	added: ocata-backport-potential

Rob Cresswell (robcresswell-deactivatedaccount) on 2017-02-03

Changed in horizon:
milestone:	next → pike-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-03: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/426984
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d256d0025f03d83e784286af5fbd06a95fb43b39
Submitter: Jenkins
Branch: master

commit d256d0025f03d83e784286af5fbd06a95fb43b39
Author: Richard Jones <email address hidden>
Date: Tue Jan 31 11:50:32 2017 +1100

Fix reporting of profiler traces with multiple toplevels

    The Profiler panel was only showing the first of potentally
    many toplevel events in a request. This patch reinstates
    those events by displaying the root event rather than
    its first child.

Change-Id: Ifeb0c3ee16168335e7b41c1063897ccdf5511800
Closes-Bug: 1660449

Changed in horizon:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-07: Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/430175

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-07: Fix merged to horizon (stable/ocata)

Reviewed: https://review.openstack.org/430175
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f5aefa03a4e465305ae4faa3b6ffe8d85a2ed061
Submitter: Jenkins
Branch: stable/ocata

commit f5aefa03a4e465305ae4faa3b6ffe8d85a2ed061
Author: Richard Jones <email address hidden>
Date: Tue Jan 31 11:50:32 2017 +1100

Fix reporting of profiler traces with multiple toplevels

    The Profiler panel was only showing the first of potentally
    many toplevel events in a request. This patch reinstates
    those events by displaying the root event rather than
    its first child.

    Change-Id: Ifeb0c3ee16168335e7b41c1063897ccdf5511800
    Closes-Bug: 1660449
    (cherry picked from commit d256d0025f03d83e784286af5fbd06a95fb43b39)