distrib_codename alpha comparison will soon yield unintended behavior
Bug #1659575 reported by
Ryan Beisner
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Charm Helpers |
Fix Released
|
High
|
Alex Kavanagh | ||
| OpenStack Keystone Charm |
Fix Released
|
High
|
Alex Kavanagh | ||
| OpenStack Nova Cloud Controller Charm |
Fix Released
|
High
|
Alex Kavanagh | ||
| OpenStack Nova Compute Charm |
Fix Released
|
High
|
Alex Kavanagh | ||
| nova-cloud-controller (Juju Charms Collection) |
Invalid
|
High
|
Unassigned | ||
| nova-compute (Juju Charms Collection) |
Invalid
|
High
|
Unassigned | ||
Bug Description
Presuming that after 'z' will come 'a' - with regard to distro codename, several charms are about to have unintended behavior due to the use of alpha comparison logic. The numeric version comparison should be used instead.
I've not done a full audit of all OpenStack Charms but that needs to be done as soon as possible, and associated with this bug.
Here are a some examples which need to be fixed:
https:/
if distro_codename < "wily":
if distro_codename >= 'yakkety':
.
Here is an example of the safe way to do it:
if lsb_release(
Related branches
lp://staging/~ajkavanagh/charm-helpers/fix-alphanumerica-comparisons
- David Ames (community): Approve
-
Diff: 674 lines (+210/-173)13 files modifiedcharmhelpers/contrib/hardening/ssh/checks/config.py (+14/-6)
charmhelpers/contrib/network/ip.py (+2/-4)
charmhelpers/contrib/openstack/amulet/utils.py (+2/-1)
charmhelpers/contrib/openstack/context.py (+2/-2)
charmhelpers/contrib/openstack/neutron.py (+12/-7)
charmhelpers/contrib/openstack/utils.py (+4/-88)
charmhelpers/core/host.py (+2/-0)
charmhelpers/core/host_factory/centos.py (+16/-0)
charmhelpers/core/host_factory/ubuntu.py (+32/-0)
charmhelpers/core/strutils.py (+53/-0)
tests/contrib/openstack/test_os_utils.py (+3/-64)
tests/core/test_host.py (+10/-1)
tests/core/test_strutils.py (+58/-0)
Revision history for this message
| Ryan Beisner (1chb1n) wrote | #1 |
Revision history for this message
| Alex Kavanagh (ajkavanagh) wrote | #2 |
| description: | updated |
Revision history for this message
| James Page (james-page) wrote | #3 |
| Changed in nova-compute (Juju Charms Collection): | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in nova-cloud-controller (Juju Charms Collection): | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in charm-helpers: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in charm-nova-compute: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in nova-compute (Juju Charms Collection): | |
| status: | Triaged → Invalid |
| Changed in charm-nova-cloud-controller: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in nova-cloud-controller (Juju Charms Collection): | |
| status: | Triaged → Invalid |
| Changed in charm-helpers: | |
| assignee: | nobody → Alex Kavanagh (ajkavanagh) |
| Changed in charm-nova-cloud-controller: | |
| assignee: | nobody → Alex Kavanagh (ajkavanagh) |
| Changed in charm-nova-compute: | |
| assignee: | nobody → Alex Kavanagh (ajkavanagh) |
| Changed in charm-keystone: | |
| importance: | Undecided → High |
| assignee: | nobody → Alex Kavanagh (ajkavanagh) |
| status: | New → In Progress |
| Changed in charm-helpers: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Related fix proposed to charm-keystone (master) | #4 |
| Changed in charm-helpers: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Related fix proposed to charm-nova-cloud-controller (master) | #5 |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Related fix proposed to charm-nova-compute (master) | #6 |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Related fix merged to charm-nova-compute (master) | #7 |
| Changed in charm-nova-cloud-controller: | |
| status: | Triaged → In Progress |
| Changed in charm-nova-compute: | |
| status: | Triaged → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Related fix merged to charm-keystone (master) | #8 |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Related fix merged to charm-nova-cloud-controller (master) | #9 |
| Changed in charm-helpers: | |
| status: | In Progress → Fix Released |
| Changed in charm-keystone: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 17.08 |
| Changed in charm-nova-cloud-controller: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 17.08 |
| Changed in charm-nova-compute: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 17.08 |
| Changed in charm-nova-compute: | |
| status: | Fix Committed → Fix Released |
| Changed in charm-nova-cloud-controller: | |
| status: | Fix Committed → Fix Released |
| Changed in charm-keystone: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Some of these alpha comparisons are in charm repos (ie. hook code), and some of them are in charmhelpers.
Here are some examples of trouble-to-come from charmhelpers:
contrib/
contrib/