change docker restart policy

Bug #1657946 reported by luyao
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Critical
luyao
Mitaka
Fix Released
Critical
Unassigned
Newton
Fix Released
Critical
Unassigned

Bug Description

kolla-ansible deploy raiser error:
TASK [common : Starting heka container] ****************************************
fatal: [10.20.11.3]: FAILED! => {"changed": true, "failed": true, "msg": "'Traceback (most recent call last):\\n File \"/tmp/ansible_UhYuWB/ansible_module_kolla_docker.py\", line 742, in main\\n result = bool(getattr(dw, module.params.get(\\'action\\'))())\\n File \"/tmp/ansible_UhYuWB/ansible_module_kolla_docker.py\", line 567, in start_container\\n self.create_container()\\n File \"/tmp/ansible_UhYuWB/ansible_module_kolla_docker.py\", line 555, in create_container\\n self.dc.create_container(**options)\\n File \"/usr/lib/python2.7/site-packages/docker/api/container.py\", line 120, in create_container\\n return self.create_container_from_config(config, name)\\n File \"/usr/lib/python2.7/site-packages/docker/api/container.py\", line 131, in create_container_from_config\\n return self._result(res, True)\\n File \"/usr/lib/python2.7/site-packages/docker/client.py\", line 178, in _result\\n self._raise_for_status(response)\\n File \"/usr/lib/python2.7/site-packages/docker/client.py\", line 174, in _raise_for_status\\n raise errors.APIError(e, response, explanation=explanation)\\nAPIError: 500 Server Error: Internal Server Error (\"{\"message\":\"maximum retry count cannot be used with restart policy \\'unless-stopped\\'\"}\")\\n'"}
        to retry, use: --limit @/home/kolla_install/kolla/ansible/site.retry

so we need to chang kolla restart policy of 'unless-stopped'

luyao (lu-yao135)
Changed in kolla:
assignee: nobody → luyao (lu-yao135)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/423026

Changed in kolla:
milestone: none → ocata-3
status: New → Confirmed
Changed in kolla:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/newton)

Reviewed: https://review.openstack.org/424114
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=d2e335e8be5943c339400c90157fffa8b84c4fc7
Submitter: Jenkins
Branch: stable/newton

commit d2e335e8be5943c339400c90157fffa8b84c4fc7
Author: Jeffrey Zhang <email address hidden>
Date: Fri Jan 20 16:32:31 2017 +0800

    Fix docker restart policy issue on docker engine 1.13

    Docker v1.25 api now validates restart policies[0]

    [0] https://github.com/docker/docker/blob/master/docs/api/version-history.md

    Change-Id: Idc90cb99cf38ab1e637568ee5dbe5adcb2fa5b78
    Closes-Bug: #1657946
    (cherry picked from commit 69b985f1b62d3ca8bdce97c04c7ce761cb70261f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 4.0.0.0b3

This issue was fixed in the openstack/kolla-ansible 4.0.0.0b3 development milestone.

Changed in kolla:
milestone: ocata-3 → ocata-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/mitaka)

Reviewed: https://review.openstack.org/424115
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=54d0cdf33e7a00dda34b9519ac4dd35024026efc
Submitter: Jenkins
Branch: stable/mitaka

commit 54d0cdf33e7a00dda34b9519ac4dd35024026efc
Author: Jeffrey Zhang <email address hidden>
Date: Fri Jan 20 16:32:31 2017 +0800

    Fix docker restart policy issue on docker engine 1.13

    Docker v1.25 api now validates restart policies[0]

    [0] https://github.com/docker/docker/blob/master/docs/api/version-history.md

    Change-Id: Idc90cb99cf38ab1e637568ee5dbe5adcb2fa5b78
    Closes-Bug: #1657946
    (cherry picked from commit 69b985f1b62d3ca8bdce97c04c7ce761cb70261f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla (stable/newton)

Change abandoned by Yao Lu (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/423026

Revision history for this message
Kuo-tung Kao (jelly) (coding1314) wrote :

The bug has fixed by the commit

https://review.openstack.org/#/c/423122/

Changed in kolla:
milestone: ocata-rc1 → pike-1
Revision history for this message
Jeffrey Zhang (jeffrey4l) wrote :

This is already fixed several days ago.

Changed in kolla:
status: Confirmed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 2.0.3

This issue was fixed in the openstack/kolla 2.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 3.0.3

This issue was fixed in the openstack/kolla 3.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.