tox -egenconfig creates empty file

Bug #1657620 reported by Aimee Ukasick
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Aimee Ukasick

Bug Description

congress master (ocata)
Note: config file generation works in stable/newton
I am trying to generate the congress.conf.sample configuration file.
http://docs.openstack.org/developer/congress/deployment.html

tox -egenconfig creates a file with only [DEFAULT] and no configuration entries. This happens locally and in my Ocata DevStack VM. I also cloned Congress in a Docker container running Ubuntu 16.04, installed dependencies, cloned master, and tox -egenconfig threw the following traceback:

genconfig runtests: commands[1] | oslo-config-generator --config-file=etc/congress-config-generator.conf
Traceback (most recent call last):
  File "/home/congress/.tox/genconfig/bin/oslo-config-generator", line 11, in <module>
    sys.exit(main())
  File "/home/congress/.tox/genconfig/local/lib/python2.7/site-packages/oslo_config/generator.py", line 526, in main
    generate(conf)
  File "/home/congress/.tox/genconfig/local/lib/python2.7/site-packages/oslo_config/generator.py", line 506, in generate
    groups = _get_groups(_list_opts(conf.namespace))
  File "/home/congress/.tox/genconfig/local/lib/python2.7/site-packages/oslo_config/generator.py", line 430, in _list_opts
    for namespace, loader in loaders
  File "/home/congress/congress/opts.py", line 36, in list_opts
    ('dse', congress.dse2.dse_node._dse_opts)
AttributeError: 'module' object has no attribute '_dse_opts'
ERROR: InvocationError: '/home/congress/.tox/genconfig/bin/oslo-config-generator --config-file=etc/congress-config-generator.conf'
ERROR: genconfig: commands failed

I looked at congress/congress/opts.py line 36
https://github.com/openstack/congress/blob/master/congress/opts.py#L36
and at congress.dse2.dse_node.py -- _dse_opts is clearly defined on line 46
https://github.com/openstack/congress/blob/master/congress/dse2/dse_node.py#L42
The issue is a combo of https://github.com/openstack/congress/blob/master/congress/dse2/dse_node.py#L61 and that _dse_opts become dse_opts.

Tags: ocata-3
Aimee Ukasick (aimeeu)
Changed in congress:
assignee: nobody → Aimee Ukasick (aimeeu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/422346

Changed in congress:
status: New → In Progress
Anusha (anusha-iiitm)
Changed in congress:
milestone: none → ocata-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/422346
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=a5f6a89a1816f605beb12265eaf1df4d915b76af
Submitter: Jenkins
Branch: master

commit a5f6a89a1816f605beb12265eaf1df4d915b76af
Author: Aimee Ukasick <email address hidden>
Date: Wed Jan 18 20:22:55 2017 -0600

    Fixes congress.conf.sample file generation

    Fixes array name and CONF registering issue that prevented
    tox -egenconfig from correctly generating the
    congress.conf.sample file.
    Refactored to move dse_opts into config.py.

    Closes-Bug: 1657620
    Partial-Bug: 1651928

    Change-Id: I4057de278323373ea45653276fb5b243eb673e2f

Changed in congress:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/congress 5.0.0.0b3

This issue was fixed in the openstack/congress 5.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.