Empty THT strings now being interpreted as actual values by puppet

Bug #1656939 reported by Brent Eagles
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Brent Eagles

Bug Description

In newton and earlier, setting an empty string in the heat templates resulted in the puppet modules interpreting the hieradata as "unset" and the puppet module default value was used instead. This no longer works this way and the empty string is used as an actual configuration value. At least one setting (the firewall driver in the neutron ovs agent) has been affected.

Arguably, using an empty string as a mechanism for dealing with "leave as defaults" is wrong anyways and is no longer necessary. I'll fix for neutron-ovs-agent and do a quick survey for other things that might be affected. It probably would be a good idea for others to keep their eyes open for other parameters that might be affected.

Brent Eagles (beagles)
Changed in tripleo:
assignee: nobody → Brent Eagles (beagles)
importance: Undecided → High
milestone: none → ocata-3
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/420947

Changed in tripleo:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/420947
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=18e6dc96e5b11d1f3708aad9aacf0c699386791f
Submitter: Jenkins
Branch: master

commit 18e6dc96e5b11d1f3708aad9aacf0c699386791f
Author: Brent Eagles <email address hidden>
Date: Mon Jan 16 17:12:54 2017 -0330

    Conditionally set OVS agent firewall driver

    Using an empty string to allow the default value in the puppet module no
    longer seems to work, resulting in the OVS agent configuration having an
    empty firewall driver configuration. This patch uses a heat template
    condition to set the hieradata only if something other than an empty
    string has been set.

    Change-Id: Ifef9ded1dbb719e75997474bf5ada909dbf40599
    Related-Bug: #1656939

Brent Eagles (beagles)
Changed in tripleo:
status: In Progress → Fix Committed
Changed in tripleo:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/425423

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.