OpenStack Dashboard (Horizon)

In drawer, 'priority' attribute should be handled conversely against rows

Bug #1651658 reported by Shu Muto on 2016-12-21

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Wishlist	Shu Muto	OpenStack Dashboard (Horizon) pike-1

Bug Description

'priority' attribute has be handled in drawer [1][2], but the behavior is same as in rows.
The behavior is that the items which have lower priority are hidden from both of row and drawer when widow width is narrower.

Drawer is used for the supplements against the row, so it should be handled conversely.
It means that items appear in drawer when they are hidden from row.

[1] https://bugs.launchpad.net/horizon/+bug/1648332
[2] https://review.openstack.org/#/c/397132/

Shu Muto (shu-mutou) on 2016-12-21

Changed in horizon:
assignee:	nobody → Shu Muto (shu-mutou)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-21: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/413462

Changed in horizon:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-03-21: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/413462
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d33939cb982ede5973f8b0cebbd5c5f55e61cd0c
Submitter: Jenkins
Branch: master

commit d33939cb982ede5973f8b0cebbd5c5f55e61cd0c
Author: Shu Muto <email address hidden>
Date: Wed Dec 21 16:33:36 2016 +0900

In drawer, handle 'priority' attribute conversely against row

    'priority' attribute has be handled in drawer [1][2], but the behavior
    is same as in rows. The behavior is that the items which have lower
    priority are hidden from both of row and drawer when wid$

    Drawer is used for the supplements against the row, so it should be
    handled conversely.
    It means that items appear in drawer when they are hidden from row.

This patch fixes it.

[1] https://bugs.launchpad.net/horizon/+bug/1648332
[2] https://review.openstack.org/#/c/397132/

Change-Id: Ia0487a1d95ba16d764546cdb374fe786a0f0f648
Closes-Bug: #1651658